From: Richard Henderson <richard.henderson@linaro.org>
To: Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org,
Alistair Francis <alistair.francis@wdc.com>
Cc: Yanan Wang <wangyanan55@huawei.com>,
qemu-trivial@nongnu.org, Andrew Jones <drjones@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH] softmmu/device_tree: Silence compiler warning with --enable-sanitizers
Date: Fri, 7 Jan 2022 12:18:18 -0800 [thread overview]
Message-ID: <4aa47d06-ba24-fb92-c2e0-cd207f7d17b5@linaro.org> (raw)
In-Reply-To: <20220107133844.145039-1-thuth@redhat.com>
On 1/7/22 5:38 AM, Thomas Huth wrote:
> diff --git a/softmmu/device_tree.c b/softmmu/device_tree.c
> index 3965c834ca..9e96f5ecd5 100644
> --- a/softmmu/device_tree.c
> +++ b/softmmu/device_tree.c
> @@ -564,7 +564,7 @@ int qemu_fdt_add_path(void *fdt, const char *path)
> return -1;
> }
>
> - while (p) {
> + do {
> name = p + 1;
> p = strchr(name, '/');
> namelen = p != NULL ? p - name : strlen(name);
> @@ -584,7 +584,7 @@ int qemu_fdt_add_path(void *fdt, const char *path)
> }
>
> parent = retval;
> - }
> + } while (p);
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
In addition, the copy between 'path' and 'p' is unnecessary -- one of the variables should
be removed. Either rename the parameter to 'p', or rename all uses to 'path'.
r~
next prev parent reply other threads:[~2022-01-07 20:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 13:38 [PATCH] softmmu/device_tree: Silence compiler warning with --enable-sanitizers Thomas Huth
2022-01-07 14:45 ` Andrew Jones
2022-01-07 14:47 ` Philippe Mathieu-Daudé
2022-01-07 20:18 ` Richard Henderson [this message]
2022-01-10 2:10 ` wangyanan (Y) via
2022-01-08 0:22 ` Alistair Francis
2022-01-10 2:03 ` wangyanan (Y) via
2022-01-10 6:39 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4aa47d06-ba24-fb92-c2e0-cd207f7d17b5@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=david@gibson.dropbear.id.au \
--cc=drjones@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).