* Re: [Qemu-devel] [PATCH] tests: cleanup ptimer-test
[not found] <1474897067-89707-1-git-send-email-pbonzini@redhat.com>
@ 2016-09-26 15:17 ` Dmitry Osipenko
2016-09-26 15:25 ` Paolo Bonzini
2016-10-13 17:29 ` Peter Maydell
1 sibling, 1 reply; 3+ messages in thread
From: Dmitry Osipenko @ 2016-09-26 15:17 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: peter.maydell
On 26.09.2016 16:37, Paolo Bonzini wrote:
> 1) ptimer-test is not a qtest---it runs the ptimer.c code directly in the
> ptimer-test process
>
> 2) ptimer-test has its own stubs file, so there is no need to add more
> stubs to stubs/vmstate.c
>
Thank you for the correction. Don't know whether I should give a r-b, but if should:
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] tests: cleanup ptimer-test
2016-09-26 15:17 ` [Qemu-devel] [PATCH] tests: cleanup ptimer-test Dmitry Osipenko
@ 2016-09-26 15:25 ` Paolo Bonzini
0 siblings, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2016-09-26 15:25 UTC (permalink / raw)
To: Dmitry Osipenko, qemu-devel; +Cc: peter.maydell
On 26/09/2016 17:17, Dmitry Osipenko wrote:
> On 26.09.2016 16:37, Paolo Bonzini wrote:
>> 1) ptimer-test is not a qtest---it runs the ptimer.c code directly in the
>> ptimer-test process
>>
>> 2) ptimer-test has its own stubs file, so there is no need to add more
>> stubs to stubs/vmstate.c
>>
>
> Thank you for the correction. Don't know whether I should give a r-b, but if should:
>
> Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
Sure, why not! :)
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] tests: cleanup ptimer-test
[not found] <1474897067-89707-1-git-send-email-pbonzini@redhat.com>
2016-09-26 15:17 ` [Qemu-devel] [PATCH] tests: cleanup ptimer-test Dmitry Osipenko
@ 2016-10-13 17:29 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2016-10-13 17:29 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: QEMU Developers, Dmitry Osipenko
On 26 September 2016 at 14:37, Paolo Bonzini <pbonzini@redhat.com> wrote:
> 1) ptimer-test is not a qtest---it runs the ptimer.c code directly in the
> ptimer-test process
>
> 2) ptimer-test has its own stubs file, so there is no need to add more
> stubs to stubs/vmstate.c
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> stubs/vmstate.c | 5 -----
> tests/Makefile.include | 5 +++--
> tests/ptimer-test-stubs.c | 7 +++++++
> tests/ptimer-test.c | 22 +++++++++++-----------
> 4 files changed, 21 insertions(+), 18 deletions(-)
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-13 17:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1474897067-89707-1-git-send-email-pbonzini@redhat.com>
2016-09-26 15:17 ` [Qemu-devel] [PATCH] tests: cleanup ptimer-test Dmitry Osipenko
2016-09-26 15:25 ` Paolo Bonzini
2016-10-13 17:29 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).