From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NuxSo-0006T9-23 for qemu-devel@nongnu.org; Thu, 25 Mar 2010 20:31:50 -0400 Received: from [140.186.70.92] (port=41662 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NuxSm-0006S4-R2 for qemu-devel@nongnu.org; Thu, 25 Mar 2010 20:31:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NuxSl-0008AQ-2m for qemu-devel@nongnu.org; Thu, 25 Mar 2010 20:31:48 -0400 Received: from mail-wy0-f173.google.com ([74.125.82.173]:48696) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NuxSk-0008AF-Uc for qemu-devel@nongnu.org; Thu, 25 Mar 2010 20:31:47 -0400 Received: by wyb42 with SMTP id 42so3669967wyb.4 for ; Thu, 25 Mar 2010 17:31:45 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <09F9B6EF-33C7-4755-82DB-CB0D60F49649@suse.de> References: <4aa8564b0912011033n68653e6dufc4bd87ccaf030a5@mail.gmail.com> <8F6B1156-5574-41A3-B2EE-978E77391EF7@suse.de> <4aa8564b1003241456y4851b964iafcc534324506666@mail.gmail.com> <09F9B6EF-33C7-4755-82DB-CB0D60F49649@suse.de> From: Dmitry Ilyevsky Date: Fri, 26 Mar 2010 03:31:25 +0300 Message-ID: <4aa8564b1003251731o2e0dc66ci603cefa86d70d87@mail.gmail.com> Subject: Re: [Qemu-devel] TBL register permissions for PPC Content-Type: multipart/mixed; boundary=0016e6d99eadbdec0e0482a9493a List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-devel@nongnu.org --0016e6d99eadbdec0e0482a9493a Content-Type: text/plain; charset=UTF-8 On Thu, Mar 25, 2010 at 10:53 AM, Alexander Graf wrote: > > On 24.03.2010, at 22:56, Dmitry Ilyevsky wrote: > >> >> Hello All, >> >> Please review patch for TBL SPR read access for generic PPC. >> >> Description: >> >> POWER specification docs define TBL/TBU SPRs as readable in user and privileged modes. Therefore SPRs permissions were changed in gen_tbl function in target-ppc/translate_init.c file. >> >> Testing: >> >> Tested with vxworks-6.2 bsp and OS on custom qemu board that includes ppc405 emulated core > > A couple of comments to this patch. > > 1) Please don't top-post. > 2) Always put a Signed-off-by: in the patch > 3) Put the patch description into the patch, so git knows what to do with it > 4) Don't use html features in mail :-) > > The patch looks good otherwise. > > > Alex > > Corrected. Thanks, Dmitry I. --0016e6d99eadbdec0e0482a9493a Content-Type: text/x-patch; charset=US-ASCII; name="0001-Generic-PowerPC-TBL.patch" Content-Disposition: attachment; filename="0001-Generic-PowerPC-TBL.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g78974kf0 RnJvbSBiNTg0NmI3ZGYxMzZjMWVmZjdkZjhkYWRhODgwMGM4MWUxNzk5Y2Y0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEbWl0cnkgSWx5ZXZza3kgPGlseWV2c2t5QGdtYWlsLmNvbT4K RGF0ZTogRnJpLCAyNiBNYXIgMjAxMCAwMzoyNTozNiArMDMwMApTdWJqZWN0OiBHZW5lcmljIFBv d2VyUEMgVEJMCgpUaW1lIGJhc2UgU1BScyBUQkwvVEJVIHNob3VsZCBiZSBhY2Nlc3NpYmxlIGlu IHVzZXIvcHJpdiBtb2RlcyBmb3IgcmVhZGluZyBhcyBzcGVjaWZpZWQgaW4gUE9XRVIgSVNBIGRv Y3VtZW50YXRpb24uIFRoZXJlZm9yZSBTUFJzIHBlcm1pc3Npb25zIHdlcmUgY2hhbmdlZCBpbiBn ZW5fdGJsIGZ1bmN0aW9uLgoKU2lnbmVkLW9mZi1ieTogRG1pdHJ5IElseWV2c2t5IDxpbHlldnNr eUBnbWFpbC5jb20+Ci0tLQogdGFyZ2V0LXBwYy90cmFuc2xhdGVfaW5pdC5jIHwgICAgOCArKysr LS0tLQogMSBmaWxlcyBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvdGFyZ2V0LXBwYy90cmFuc2xhdGVfaW5pdC5jIGIvdGFyZ2V0LXBwYy90cmFu c2xhdGVfaW5pdC5jCmluZGV4IGRiNGRjMTcuLmU4ZWFkZjQgMTAwNjQ0Ci0tLSBhL3RhcmdldC1w cGMvdHJhbnNsYXRlX2luaXQuYworKysgYi90YXJnZXQtcHBjL3RyYW5zbGF0ZV9pbml0LmMKQEAg LTc3NywxNiArNzc3LDE2IEBAIHN0YXRpYyB2b2lkIGdlbl90YmwgKENQVVBQQ1N0YXRlICplbnYp CiAgICAgICAgICAgICAgICAgICZzcHJfcmVhZF90YmwsIFNQUl9OT0FDQ0VTUywKICAgICAgICAg ICAgICAgICAgMHgwMDAwMDAwMCk7CiAgICAgc3ByX3JlZ2lzdGVyKGVudiwgU1BSX1RCTCwgICAi VEJMIiwKLSAgICAgICAgICAgICAgICAgU1BSX05PQUNDRVNTLCBTUFJfTk9BQ0NFU1MsCi0gICAg ICAgICAgICAgICAgIFNQUl9OT0FDQ0VTUywgJnNwcl93cml0ZV90YmwsCisgICAgICAgICAgICAg ICAgICZzcHJfcmVhZF90YmwsIFNQUl9OT0FDQ0VTUywKKyAgICAgICAgICAgICAgICAgJnNwcl9y ZWFkX3RibCwgJnNwcl93cml0ZV90YmwsCiAgICAgICAgICAgICAgICAgIDB4MDAwMDAwMDApOwog ICAgIHNwcl9yZWdpc3RlcihlbnYsIFNQUl9WVEJVLCAgIlRCVSIsCiAgICAgICAgICAgICAgICAg ICZzcHJfcmVhZF90YnUsIFNQUl9OT0FDQ0VTUywKICAgICAgICAgICAgICAgICAgJnNwcl9yZWFk X3RidSwgU1BSX05PQUNDRVNTLAogICAgICAgICAgICAgICAgICAweDAwMDAwMDAwKTsKICAgICBz cHJfcmVnaXN0ZXIoZW52LCBTUFJfVEJVLCAgICJUQlUiLAotICAgICAgICAgICAgICAgICBTUFJf Tk9BQ0NFU1MsIFNQUl9OT0FDQ0VTUywKLSAgICAgICAgICAgICAgICAgU1BSX05PQUNDRVNTLCAm c3ByX3dyaXRlX3RidSwKKyAgICAgICAgICAgICAgICAgJnNwcl9yZWFkX3RidSwgU1BSX05PQUND RVNTLAorICAgICAgICAgICAgICAgICAmc3ByX3JlYWRfdGJ1LCAmc3ByX3dyaXRlX3RidSwKICAg ICAgICAgICAgICAgICAgMHgwMDAwMDAwMCk7CiB9CiAKLS0gCjEuNy4wCgo= --0016e6d99eadbdec0e0482a9493a--