From: Thomas Huth <thuth@redhat.com>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org
Cc: aurelien@aurel32.net, David Hildenbrand <david@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] target/s390x: Implement CSST
Date: Tue, 20 Jun 2017 06:58:10 +0200 [thread overview]
Message-ID: <4aae0af2-8563-ab13-3bec-b55ccf55ff7b@redhat.com> (raw)
In-Reply-To: <4c0385c0-ee69-013d-1dcb-573548fc9128@twiddle.net>
On 20.06.2017 01:44, Richard Henderson wrote:
> On 06/19/2017 01:08 AM, Thomas Huth wrote:
>>> + /* Sanity check the function code and storage characteristic. */
>>> + if (fc > 1 || sc > 3) {
>>> + if (!s390_has_feat(S390_FEAT_COMPARE_AND_SWAP_AND_STORE_2)) {
>>> + goto spec_exception;
>>> + }
>>> + if (fc > 2 || sc > 4 || (fc == 2 && (r3 & 1))) {
>>
>> I think you could omit the "fc == 2" here. fc has to be bigger than 1
>> due to the outer if-statement, and if it is not 2, the first "fc > 1"
>> has already triggered. So "fc" has to be 2 here and the "fc == 2" is a
>> redundant check.
>
> Not so. We can also get here with fc == 0 && sc == 4.
Uh, right, sorry for the confusion!
Thomas
next prev parent reply other threads:[~2017-06-20 4:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 20:37 [Qemu-devel] [PATCH] target/s390x: Implement CSST Richard Henderson
2017-06-19 8:08 ` Thomas Huth
2017-06-19 15:20 ` Richard Henderson
2017-06-19 23:44 ` Richard Henderson
2017-06-20 4:58 ` Thomas Huth [this message]
2017-06-19 10:03 ` David Hildenbrand
2017-06-19 12:05 ` David Hildenbrand
2017-06-19 12:33 ` Christian Borntraeger
2017-06-19 12:41 ` David Hildenbrand
2017-06-19 12:47 ` Christian Borntraeger
2017-06-19 12:52 ` David Hildenbrand
2017-06-19 13:00 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4aae0af2-8563-ab13-3bec-b55ccf55ff7b@redhat.com \
--to=thuth@redhat.com \
--cc=aurelien@aurel32.net \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).