Re: [PATCH] hw/usb/hcd-dwc2: Simplified I/O memory regions

[Paul Zimmerman <pauldzim@gmail.com>]

On 4/21/20 12:13 AM, Philippe Mathieu-Daudé wrote:
> Use 1 container holding 2 regions:
> - I/O registers
> - FIFOs
> 
> Remove all the static base addresses.
> 
> Name address space.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> Sometime a patch is cleaner/quicker than explanations.
> Suggestion to be squashed on patch:
> 'dwc-hsotg (dwc2) USB host controller emulation'
> 
> Further simplificatio would be to move some exploded read/write
> functions directly into dwc2_hsotg_read/write.
> 
> Based-on: <20200421014551.10426-1-pauldzim@gmail.com>
> ---
>   hw/usb/hcd-dwc2.h |  17 +----
>   hw/usb/hcd-dwc2.c | 181 ++++++++++++++++++++++------------------------
>   2 files changed, 88 insertions(+), 110 deletions(-)

<snip>

Ooh, yes, that looks much cleaner and simpler, thanks! I will test this
and fold it into the next version of the patch.

>   static Property dwc2_usb_properties[] = {
>       DEFINE_PROP_UINT32("usb_version", DWC2State, usb_version, 2),
> +    /* FIXME isn't 'usb_version=2' const? */

This allows to switch between full-speed and high-speed at boot time,
which I've found very useful for testing purposes.

> +    DEFINE_PROP_END_OF_LIST()
>   };
>   
>   static void dwc2_class_init(ObjectClass *klass, void *data)

Thanks,
Paul