Re: [PATCH v2 1/2] tests/vhost-user-bridge: move to contrib/

[Laurent Vivier <lvivier@redhat.com>]

On 02/03/2020 14:12, Philippe Mathieu-Daudé wrote:
> On 3/2/20 1:30 PM, Laurent Vivier wrote:
>> On 02/03/2020 12:19, Laurent Vivier wrote:
>>> On 02/03/2020 11:53, Michael S. Tsirkin wrote:
>>>> On Mon, Mar 02, 2020 at 10:50:16AM +0100, Laurent Vivier wrote:
>>>>> On 01/03/2020 13:12, Michael S. Tsirkin wrote:
>>>>>> On Fri, Feb 07, 2020 at 10:54:11AM +0100, Laurent Vivier wrote:
>>>>>>> vhost-user-bridge is not a test. Move it to contrib/ and
>>>>>>> add it to the tools list.
>>>>>>>
>>>>>>> It will be built only if tools (--enable-tools) and
>>>>>>> vhost-user (--enable-vhost-user) are enabled (both are set
>>>>>>> by default).
>>>>>>>
>>>>>>> Suggested-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>>>>>>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>>>>>>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>>>>>
>>>>>>
>>>>>> I had to drop this series from my tree since it cause failures
>>>>>> on OSX. Pls use something like travis CI to test when you repost
>>>>>> a fixed version. Thanks!
>>>>>>
>>>>>
>>>>> Do you have a link to the error logs?
>>>>>
>>>>> Thanks,
>>>>> Laurent
>>>>
>>>>
>>>> Peter sent me this:
>>>>
>>>>
>>>> Hi; this fails to build on OSX:
>>>>
>>>>    CC      contrib/libvhost-user/libvhost-user.o
>>>> /Users/pm215/src/qemu-for-merges/contrib/libvhost-user/libvhost-user.c:27:10:
>>>>
>>>> fatal error: 'sys/eventfd.h' file not found
>>>> #include <sys/eventfd.h>
>>>>           ^~~~~~~~~~~~~~~
>>>> In file included from
>>>> /Users/pm215/src/qemu-for-merges/contrib/vhost-user-bridge/main.c:37:
>>>> /Users/pm215/src/qemu-for-merges/contrib/libvhost-user/libvhost-user.h:21:10:
>>>>
>>>> fatal error: 'linux/vhost.h' file not found
>>>> #include <linux/vhost.h>
>>>>           ^~~~~~~~~~~~~~~
>>>> 1 error generated.
>>>>
>>>> thanks
>>>> -- PMM
>>>>
>>>> But pls do test on OSX before reposting.
>>>>
>>>
>>> Thank you.
>>>
>>> I will fix and test the new patch with Travis CI.
>>
>> In fact, travis was enabled when I sent the series but the QEMU
>> .travis.yml disables the tools so the vhost-user-bridge was not built.
> 
> Can you send a patch to enable them?

I don't know the best way to do that.

Perhaps to define a BASE_CONFIG with --enable-tools in "OSX Xcode 10.3"
section?

Thanks,
Laurent