From: Thomas Huth <thuth@redhat.com>
To: Aleksandar Markovic <aleksandar.m.mail@gmail.com>,
Michael Rolnik <mrolnik@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>
Cc: Sarah Harris <S.E.Harris@kent.ac.uk>,
"richard.henderson@linaro.org" <richard.henderson@linaro.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"dovgaluk@ispras.ru" <dovgaluk@ispras.ru>,
"imammedo@redhat.com" <imammedo@redhat.com>,
"philmd@redhat.com" <philmd@redhat.com>
Subject: Re: [PATCH v36 01/17] target/avr: Add outward facing interfaces and core CPU logic
Date: Mon, 25 Nov 2019 19:51:26 +0100 [thread overview]
Message-ID: <4ac75c83-ee30-e93c-c8f1-5f83df588e0d@redhat.com> (raw)
In-Reply-To: <CAL1e-=iiu+8a60SY=83CTSQfPZ+aOsGoZhJNMOLGtmLq8a90OA@mail.gmail.com>
On 24/11/2019 16.17, Aleksandar Markovic wrote:
>
>
> On Sunday, November 24, 2019, Michael Rolnik <mrolnik@gmail.com
> <mailto:mrolnik@gmail.com>> wrote:
>
> This includes:
> - CPU data structures
> - object model classes and functions
> - migration functions
> - GDB hooks
>
> Co-developed-by: Michael Rolnik <mrolnik@gmail.com
> <mailto:mrolnik@gmail.com>>
> Co-developed-by: Sarah Harris <S.E.Harris@kent.ac.uk
> <mailto:S.E.Harris@kent.ac.uk>>
> Signed-off-by: Michael Rolnik <mrolnik@gmail.com
> <mailto:mrolnik@gmail.com>>
> Signed-off-by: Sarah Harris <S.E.Harris@kent.ac.uk
> <mailto:S.E.Harris@kent.ac.uk>>
> Signed-off-by: Michael Rolnik <mrolnik@gmail.com
> <mailto:mrolnik@gmail.com>>
> Acked-by: Igor Mammedov <imammedo@redhat.com
> <mailto:imammedo@redhat.com>>
> ---
> target/avr/cpu-param.h | 37 +++
> target/avr/cpu-qom.h | 54 ++++
> target/avr/cpu.h | 253 ++++++++++++++++++
> target/avr/cpu.c | 576 +++++++++++++++++++++++++++++++++++++++++
> target/avr/gdbstub.c | 85 ++++++
> target/avr/machine.c | 121 +++++++++
> gdb-xml/avr-cpu.xml | 49 ++++
> 7 files changed, 1175 insertions(+)
> create mode 100644 target/avr/cpu-param.h
> create mode 100644 target/avr/cpu-qom.h
> create mode 100644 target/avr/cpu.h
> create mode 100644 target/avr/cpu.c
> create mode 100644 target/avr/gdbstub.c
> create mode 100644 target/avr/machine.c
> create mode 100644 gdb-xml/avr-cpu.xml
>
> diff --git a/target/avr/cpu-param.h b/target/avr/cpu-param.h
> new file mode 100644
> index 0000000000..ccd1ea3429
> --- /dev/null
> +++ b/target/avr/cpu-param.h
> @@ -0,0 +1,37 @@
> +/*
> + * QEMU AVR CPU
> + *
> + * Copyright (c) 2019 Michael Rolnik
> + *
> + * This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
>
>
> I think version 2 would be more fitting to QEMU ovarall license than 2.1
> (see LICENCE file in QEMU root dir).
>
> Peter, am I right or wrong regarding GPL 2 vs. 2.1 (My interpretation is
> that 2 is the best "default" for new files)? The wording in "LICENSE" is
> frankly not entirely clear, and I see many new files using 2.1.
Hi Aleksandar,
I think you mix up GPL and LGPL here. This file is licensed under the
LGPL, so version 2.1 is perfectly fine here (see COPYING.LIB in the root
directory). For the GPL, there was never a 2.1, so if it would be GPL,
version 2 would be appropriate. Bit since it's LGPL, 2.1 is better indeed.
Thomas
next prev parent reply other threads:[~2019-11-25 18:53 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-24 5:02 [PATCH v36 00/17] QEMU AVR 8 bit cores Michael Rolnik
2019-11-24 5:02 ` [PATCH v36 01/17] target/avr: Add outward facing interfaces and core CPU logic Michael Rolnik
2019-11-24 15:17 ` Aleksandar Markovic
2019-11-25 18:51 ` Thomas Huth [this message]
2019-11-25 19:06 ` Aleksandar Markovic
2019-11-24 16:21 ` Aleksandar Markovic
2019-11-24 20:08 ` Aleksandar Markovic
2019-11-26 22:54 ` Philippe Mathieu-Daudé
2019-11-25 1:29 ` Aleksandar Markovic
2019-11-26 1:25 ` Aleksandar Markovic
2019-11-24 5:02 ` [PATCH v36 02/17] target/avr: Add instruction helpers Michael Rolnik
2019-11-24 5:02 ` [PATCH v36 03/17] target/avr: Add instruction decoding Michael Rolnik
2019-11-24 15:22 ` Aleksandar Markovic
2019-11-24 5:02 ` [PATCH v36 04/17] target/avr: Add instruction translation - Registers definition Michael Rolnik
2019-11-26 19:48 ` Aleksandar Markovic
2019-11-26 20:40 ` Michael Rolnik
2019-11-26 23:06 ` Philippe Mathieu-Daudé
2019-11-24 5:02 ` [PATCH v36 05/17] target/avr: Add instruction translation - Arithmetic and Logic Instructions Michael Rolnik
2019-11-26 23:04 ` Philippe Mathieu-Daudé
2019-11-24 5:02 ` [PATCH v36 06/17] target/avr: Add instruction translation - Branch Instructions Michael Rolnik
2019-11-26 23:04 ` Philippe Mathieu-Daudé
2019-11-24 5:02 ` [PATCH v36 07/17] target/avr: Add instruction translation - Bit and Bit-test Instructions Michael Rolnik
2019-11-24 5:02 ` [PATCH v36 08/17] target/avr: Add instruction translation - MCU Control Instructions Michael Rolnik
2019-11-24 5:02 ` [PATCH v36 09/17] target/avr: Add instruction translation - CPU main translation function Michael Rolnik
2019-11-24 5:02 ` [PATCH v36 10/17] target/avr: Add instruction disassembly function Michael Rolnik
2019-11-24 15:02 ` Aleksandar Markovic
2019-11-24 15:05 ` Aleksandar Markovic
2019-11-26 1:11 ` Aleksandar Markovic
2019-11-26 19:52 ` Aleksandar Markovic
2019-11-26 20:32 ` Michael Rolnik
2019-11-26 22:24 ` Aleksandar Markovic
2019-11-26 23:14 ` Aleksandar Markovic
2019-11-26 23:59 ` Philippe Mathieu-Daudé
2019-11-27 6:21 ` Michael Rolnik
2019-11-24 5:02 ` [PATCH v36 11/17] target/avr: Add limited support for USART and 16 bit timer peripherals Michael Rolnik
2019-11-24 14:58 ` Aleksandar Markovic
2019-11-27 17:07 ` Philippe Mathieu-Daudé
2019-11-27 18:43 ` Aleksandar Markovic
2019-11-27 18:46 ` Michael Rolnik
2019-11-27 19:29 ` Aleksandar Markovic
2019-11-27 20:02 ` Aleksandar Markovic
2019-11-24 5:02 ` [PATCH v36 12/17] target/avr: Add example board configuration Michael Rolnik
2019-11-26 1:08 ` Aleksandar Markovic
2019-11-26 23:03 ` Philippe Mathieu-Daudé
2019-11-24 5:02 ` [PATCH v36 13/17] target/avr: Register AVR support with the rest of QEMU Michael Rolnik
2019-11-24 5:02 ` [PATCH v36 14/17] target/avr: Update build system Michael Rolnik
2019-11-24 5:02 ` [PATCH v36 15/17] target/avr: Add boot serial test Michael Rolnik
2019-11-24 5:02 ` [PATCH v36 16/17] target/avr: Add Avocado test Michael Rolnik
2019-11-24 15:18 ` Aleksandar Markovic
2019-11-26 23:14 ` Philippe Mathieu-Daudé
2019-11-24 5:02 ` [PATCH v36 17/17] target/avr: Update MAINTAINERS file Michael Rolnik
2019-11-25 23:49 ` Aleksandar Markovic
2019-11-26 2:06 ` Cleber Rosa
2019-11-27 23:53 ` Eduardo Habkost
2019-11-26 3:17 ` Aleksandar Markovic
2019-11-26 19:05 ` Michael Rolnik
2019-11-26 19:39 ` Aleksandar Markovic
2019-11-26 20:41 ` Michael Rolnik
2019-11-28 9:34 ` Sarah Harris
2019-11-25 8:47 ` [PATCH v36 00/17] QEMU AVR 8 bit cores Philippe Mathieu-Daudé
2019-11-25 23:58 ` Aleksandar Markovic
2019-11-26 1:22 ` Aleksandar Markovic
2019-11-26 23:21 ` Aleksandar Markovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ac75c83-ee30-e93c-c8f1-5f83df588e0d@redhat.com \
--to=thuth@redhat.com \
--cc=S.E.Harris@kent.ac.uk \
--cc=aleksandar.m.mail@gmail.com \
--cc=dovgaluk@ispras.ru \
--cc=imammedo@redhat.com \
--cc=mrolnik@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).