From: Richard Henderson <richard.henderson@linaro.org>
To: Aaron Lindsay <Aaron@os.amperecomputing.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"peter.maydell@linaro.org" <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH 3/3] target/arm: Flush only the TLBs affected by TTBR*_EL1
Date: Thu, 18 Oct 2018 13:52:23 -0700 [thread overview]
Message-ID: <4b0c801d-e119-75ab-01ae-85dc1cbba705@linaro.org> (raw)
In-Reply-To: <20181018202719.GG12691@quinoa.localdomain>
On 10/18/18 1:27 PM, Aaron Lindsay wrote:
> On Oct 18 11:27, Richard Henderson wrote:
>> @@ -2761,12 +2763,12 @@ static const ARMCPRegInfo vmsa_cp_reginfo[] = {
>> .fieldoffset = offsetof(CPUARMState, cp15.esr_el[1]), .resetvalue = 0, },
>> { .name = "TTBR0_EL1", .state = ARM_CP_STATE_BOTH,
>> .opc0 = 3, .opc1 = 0, .crn = 2, .crm = 0, .opc2 = 0,
>> - .access = PL1_RW, .writefn = vmsa_ttbr_write, .resetvalue = 0,
>> + .access = PL1_RW, .writefn = vmsa_ttbr1_write, .resetvalue = 0,
>
> It's a little confusing that vmsa_ttbr1_write is used for TTBR0_EL1. Is
> the '1' indicating the EL instead of which TTBR is being used?
Yes. Perhaps I should have included "_el" in the symbol for clarity.
I expect to add a different function (vmsr_ttbr_el2_write?), for TTBR{0,1}_EL2,
which will also check HCR_EL2.E2H, when I get around to implementing ARMv8.1-VHE.
r~
prev parent reply other threads:[~2018-10-18 20:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 18:27 [Qemu-devel] [PATCH 0/3] target/arm: Reduce tlb_flush overhead Richard Henderson
2018-10-18 18:27 ` [Qemu-devel] [PATCH 1/3] target/arm: Remove writefn from TTBR0_EL3 Richard Henderson
2018-10-18 20:28 ` Aaron Lindsay
2018-10-18 18:27 ` [Qemu-devel] [PATCH 2/3] target/arm: Only flush tlb if ASID changes Richard Henderson
2018-10-18 20:28 ` Aaron Lindsay
2018-10-18 18:27 ` [Qemu-devel] [PATCH 3/3] target/arm: Flush only the TLBs affected by TTBR*_EL1 Richard Henderson
2018-10-18 20:27 ` Aaron Lindsay
2018-10-18 20:52 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b0c801d-e119-75ab-01ae-85dc1cbba705@linaro.org \
--to=richard.henderson@linaro.org \
--cc=Aaron@os.amperecomputing.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).