qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>, qemu-devel@nongnu.org
Cc: Song Gao <gaosong@loongson.cn>
Subject: Re: [PATCH v2 6/9] target/loongarch: Fix some modifiers for log formatting
Date: Tue, 25 Feb 2025 15:44:01 +0100	[thread overview]
Message-ID: <4b103a04-b119-4704-b7c9-d8e3bb482832@linaro.org> (raw)
In-Reply-To: <20250225-la32-fixes1-v2-6-8ec68ada3dd5@flygoat.com>

On 25/2/25 01:40, Jiaxun Yang wrote:
> target_ulong -> TARGET_FMT_ld
> vaddr -> VADDR_PRIx
> uint32_t -> PRIx32
> 
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
>   target/loongarch/tcg/insn_trans/trans_atomic.c.inc | 2 +-
>   target/loongarch/tcg/tlb_helper.c                  | 2 +-
>   target/loongarch/tcg/translate.c                   | 5 ++---
>   3 files changed, 4 insertions(+), 5 deletions(-)


> diff --git a/target/loongarch/tcg/tlb_helper.c b/target/loongarch/tcg/tlb_helper.c
> index 97f38fc391338ba4b76115b142fa76d89e45cd62..a1426b46f36c99e300ab924cb487875ec21ab226 100644
> --- a/target/loongarch/tcg/tlb_helper.c
> +++ b/target/loongarch/tcg/tlb_helper.c
> @@ -517,7 +517,7 @@ target_ulong helper_lddir(CPULoongArchState *env, target_ulong base,
>   
>       if (unlikely((level == 0) || (level > 4))) {
>           qemu_log_mask(LOG_GUEST_ERROR,
> -                      "Attepted LDDIR with level %"PRId64"\n", level);
> +                      "Attepted LDDIR with level "TARGET_FMT_ld"\n", level);

"Attempted"?

>           return base;
>       }


  reply	other threads:[~2025-02-25 14:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-25  0:40 [PATCH v2 0/9] target/loongarch: LoongArch32 fixes 1 Jiaxun Yang
2025-02-25  0:40 ` [PATCH v2 1/9] target/loongarch: Enable rotr.w/rotri.w for LoongArch32 Jiaxun Yang
2025-02-25  0:40 ` [PATCH v2 2/9] target/loongarch: Fix address generation for gen_sc Jiaxun Yang
2025-02-25  0:40 ` [PATCH v2 3/9] target/loongarch: Fix PGD CSR for LoongArch32 Jiaxun Yang
2025-02-25 14:40   ` Philippe Mathieu-Daudé
2025-02-25  0:40 ` [PATCH v2 4/9] target/loongarch: Perform sign extension for IOCSR reads Jiaxun Yang
2025-02-25  0:40 ` [PATCH v2 5/9] target/loongarch: Use target_ulong for iocsrrd helper results Jiaxun Yang
2025-02-25  0:40 ` [PATCH v2 6/9] target/loongarch: Fix some modifiers for log formatting Jiaxun Yang
2025-02-25 14:44   ` Philippe Mathieu-Daudé [this message]
2025-02-25  0:40 ` [PATCH v2 7/9] target/loongarch: Use target_ulong for CSR helpers Jiaxun Yang
2025-02-25  0:40 ` [PATCH v2 8/9] target/loongarch: Fix load type for gen_ll Jiaxun Yang
2025-02-25  0:40 ` [PATCH v2 9/9] target/loongarch: Introduce max32 CPU type Jiaxun Yang
2025-02-25  8:50 ` [PATCH v2 0/9] target/loongarch: LoongArch32 fixes 1 bibo mao
2025-02-25 12:08   ` Jiaxun Yang
2025-02-25 12:33     ` bibo mao
2025-02-27 10:44       ` Jiaxun Yang
2025-02-27 12:21         ` bibo mao
2025-02-27 12:36           ` Jiaxun Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b103a04-b119-4704-b7c9-d8e3bb482832@linaro.org \
    --to=philmd@linaro.org \
    --cc=gaosong@loongson.cn \
    --cc=jiaxun.yang@flygoat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).