From: Paolo Bonzini <pbonzini@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>, peter.maydell@linaro.org
Cc: lvivier@redhat.com, surajjs@au1.ibm.com, groug@kaod.org,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Subject: Re: [Qemu-devel] [PULL 12/12] target/ppc/spapr: Add H-Call H_GET_CPU_CHARACTERISTICS
Date: Thu, 1 Feb 2018 13:22:43 -0500 [thread overview]
Message-ID: <4b1b39cd-944b-b90f-5d19-61b34edfdf48@redhat.com> (raw)
In-Reply-To: <20180129032826.16876-13-david@gibson.dropbear.id.au>
On 28/01/2018 22:28, David Gibson wrote:
> + switch (safe_indirect_branch) {
> + case SPAPR_CAP_FIXED:
> + characteristics |= H_CPU_CHAR_BCCTRL_SERIALISED;
Missing "break;" here.
Paolo
> + default: /* broken */
> + assert(safe_indirect_branch == SPAPR_CAP_BROKEN);
> + break;
next prev parent reply other threads:[~2018-02-01 18:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 3:28 [Qemu-devel] [PULL 00/12] ppc-for-2.12 queue 20180129 David Gibson
2018-01-29 3:28 ` [Qemu-devel] [PULL 01/12] ppc/pnv: fix PnvChip redefinition in <hw/ppc/pnv_xscom.h> David Gibson
2018-01-29 3:28 ` [Qemu-devel] [PULL 02/12] ppc: Deprecate qemu-system-ppcemb David Gibson
2018-01-29 3:28 ` [Qemu-devel] [PULL 03/12] grackle: convert to trace-events David Gibson
2018-01-29 3:28 ` [Qemu-devel] [PULL 04/12] uninorth: " David Gibson
2018-01-29 3:28 ` [Qemu-devel] [PULL 05/12] input: add missing newline from trace-events David Gibson
2018-01-29 3:28 ` [Qemu-devel] [PULL 06/12] spapr_pci: fix MSI/MSIX selection David Gibson
2018-01-29 3:28 ` [Qemu-devel] [PULL 07/12] target/ppc/kvm: Add cap_ppc_safe_[cache/bounds_check/indirect_branch] David Gibson
2018-01-29 3:28 ` [Qemu-devel] [PULL 08/12] target/ppc/spapr_caps: Add support for tristate spapr_capabilities David Gibson
2018-01-29 3:28 ` [Qemu-devel] [PULL 09/12] target/ppc/spapr_caps: Add new tristate cap safe_cache David Gibson
2018-01-29 3:28 ` [Qemu-devel] [PULL 10/12] target/ppc/spapr_caps: Add new tristate cap safe_bounds_check David Gibson
2018-01-29 3:28 ` [Qemu-devel] [PULL 11/12] target/ppc/spapr_caps: Add new tristate cap safe_indirect_branch David Gibson
2018-01-29 3:28 ` [Qemu-devel] [PULL 12/12] target/ppc/spapr: Add H-Call H_GET_CPU_CHARACTERISTICS David Gibson
2018-02-01 18:22 ` Paolo Bonzini [this message]
2018-01-29 3:47 ` [Qemu-devel] [PULL 00/12] ppc-for-2.12 queue 20180129 no-reply
2018-01-29 14:28 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b1b39cd-944b-b90f-5d19-61b34edfdf48@redhat.com \
--to=pbonzini@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=lvivier@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=sjitindarsingh@gmail.com \
--cc=surajjs@au1.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).