qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: mingli.yu@windriver.com, qemu-devel@nongnu.org
Subject: Re: [PATCH] lockable.h: always define unknown_lock_type
Date: Sun, 13 Sep 2020 19:00:07 -0700	[thread overview]
Message-ID: <4b20315c-e75d-904c-99d5-3a844ed3bb66@linaro.org> (raw)
In-Reply-To: <20200914014236.2355289-1-mingli.yu@windriver.com>

On 9/13/20 6:42 PM, mingli.yu@windriver.com wrote:
> From: Mingli Yu <mingli.yu@windriver.com>
> 
> There comes below build failure when use gcc 10.1.0 and
> "-Og" passed to compiler.
>  | /usr/lib/gcc/x86_64-wrs-linux/10.1.0/../../../../x86_64-wrs-linux/bin/ld.bfd: /mnt/build/tmp/work/x86_64-linux/qemu-system-native/5.1.0-r0/qemu-5.1.0/fsdev/qemu-fsdev-throttle.c:25: undefined reference to `unknown_lock_type'
>  | /usr/lib/gcc/x86_64-wrs-linux/10.1.0/../../../../x86_64-wrs-linux/bin/ld.bfd: ../fsdev/qemu-fsdev-throttle.o: in function `fsdev_co_throttle_request':
>  | /mnt/build/tmp/work/x86_64-linux/qemu-system-native/5.1.0-r0/qemu-5.1.0/fsdev/qemu-fsdev-throttle.c:103: undefined reference to `unknown_lock_type'
>  | /usr/lib/gcc/x86_64-wrs-linux/10.1.0/../../../../x86_64-wrs-linux/bin/ld.bfd: ../fsdev/qemu-fsdev-throttle.o:/mnt/build/tmp/work/x86_64-linux/qemu-system-native/5.1.0-r0/qemu-5.1.0/fsdev/qemu-fsdev-throttle.c:103: more undefined references to `unknown_lock_type' follow
>  | collect2: error: ld returned 1 exit status
> 
> So always define unknown_lock_type to fix the above error.

There's a lot that won't work with -Og, including stuff that uses
qemu_build_not_reached (which this itself should have been using).


r~


  reply	other threads:[~2020-09-14  2:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-14  1:42 [PATCH] lockable.h: always define unknown_lock_type mingli.yu
2020-09-14  2:00 ` Richard Henderson [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-09-10  2:36 mingli.yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b20315c-e75d-904c-99d5-3a844ed3bb66@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=mingli.yu@windriver.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).