From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
"Janosch Frank" <frankja@linux.ibm.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [PATCH v4 4/7] dump: Introduce win_dump_available()
Date: Thu, 23 Feb 2023 13:43:24 -1000 [thread overview]
Message-ID: <4b24a2c5-3013-48ee-f133-7fa3998d4f0e@linaro.org> (raw)
In-Reply-To: <20230223231755.81633-5-philmd@linaro.org>
On 2/23/23 13:17, Philippe Mathieu-Daudé wrote:
> @@ -2130,12 +2136,10 @@ void qmp_dump_guest_memory(bool paging, const char *file,
> }
> #endif
>
> -#ifndef TARGET_X86_64
> - if (has_format && format == DUMP_GUEST_MEMORY_FORMAT_WIN_DMP) {
> - error_setg(errp, "Windows dump is only available for x86-64");
> + if (has_format && format == DUMP_GUEST_MEMORY_FORMAT_WIN_DMP
> + && !win_dump_available(errp)) {
Indentation is off.
Otherwise looks plausible as an intermediate step before more targets.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2023-02-23 23:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 23:17 [PATCH v4 0/7] dump: Make most of it target agnostic (build once) Philippe Mathieu-Daudé
2023-02-23 23:17 ` [PATCH v4 1/7] dump: Replace tswapN() -> cpu_to_dumpN() Philippe Mathieu-Daudé
2023-02-23 23:29 ` Richard Henderson
2023-02-24 7:00 ` Thomas Huth
2023-02-23 23:17 ` [PATCH v4 2/7] dump: Replace TARGET_PAGE_SIZE -> qemu_target_page_size() Philippe Mathieu-Daudé
2023-02-23 23:30 ` Richard Henderson
2023-02-24 7:01 ` Thomas Huth
2023-02-23 23:17 ` [PATCH v4 3/7] dump: Correct headers included Philippe Mathieu-Daudé
2023-02-23 23:32 ` Richard Henderson
2023-02-24 7:02 ` Thomas Huth
2023-02-23 23:17 ` [PATCH v4 4/7] dump: Introduce win_dump_available() Philippe Mathieu-Daudé
2023-02-23 23:43 ` Richard Henderson [this message]
2023-02-24 7:08 ` Thomas Huth
2023-02-23 23:17 ` [PATCH v4 5/7] dump: Introduce create_win_dump() Philippe Mathieu-Daudé
2023-02-23 23:43 ` Richard Henderson
2023-02-24 7:08 ` Thomas Huth
2023-02-23 23:17 ` [PATCH v4 6/7] dump: Build once by adding stubs for non-x86 targets Philippe Mathieu-Daudé
2023-02-23 23:51 ` Richard Henderson
2023-02-24 6:53 ` Philippe Mathieu-Daudé
2023-02-23 23:17 ` [PATCH v4 7/7] dump: Rename x86-specific file as win_dump_x86.c Philippe Mathieu-Daudé
2023-02-23 23:22 ` Philippe Mathieu-Daudé
2023-02-23 23:52 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b24a2c5-3013-48ee-f133-7fa3998d4f0e@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=frankja@linux.ibm.com \
--cc=marcandre.lureau@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).