From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] ehci: drop pointless warn_report for guest bugs.
Date: Wed, 22 Jul 2020 09:50:41 +0200 [thread overview]
Message-ID: <4b259c5c-3d23-9dfb-2884-0c1db34d0c68@redhat.com> (raw)
In-Reply-To: <20200722072613.10390-1-kraxel@redhat.com>
On 7/22/20 9:26 AM, Gerd Hoffmann wrote:
> We have a tracepoint at the same place which can be enabled if needed.
>
> Buglink: https://bugzilla.redhat.com//show_bug.cgi?id=1859236
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> hw/usb/hcd-ehci.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
> index 1495e8f7fab1..4266765f8682 100644
> --- a/hw/usb/hcd-ehci.c
> +++ b/hw/usb/hcd-ehci.c
> @@ -352,7 +352,6 @@ static void ehci_trace_sitd(EHCIState *s, hwaddr addr,
> static void ehci_trace_guest_bug(EHCIState *s, const char *message)
> {
> trace_usb_ehci_guest_bug(message);
> - warn_report("%s", message);
> }
>
> static inline bool ehci_enabled(EHCIState *s)
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
prev parent reply other threads:[~2020-07-22 7:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 7:26 [PATCH] ehci: drop pointless warn_report for guest bugs Gerd Hoffmann
2020-07-22 7:50 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b259c5c-3d23-9dfb-2884-0c1db34d0c68@redhat.com \
--to=philmd@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).