qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Roman Kiryanov <rkir@google.com>, qemu-devel@nongnu.org
Cc: jansene@google.com, mett@google.com, jpcottin@google.com
Subject: Re: [PATCH 3/3] exec: use char* for pointer arithmetic
Date: Thu, 20 Jun 2024 20:06:18 +0200	[thread overview]
Message-ID: <4b3d0472-8b06-403a-9ab8-553aa858fb7f@redhat.com> (raw)
In-Reply-To: <20240618224604.879275-1-rkir@google.com>

On 6/19/24 00:46, Roman Kiryanov wrote:
> void* pointer arithmetic is not in the
> C standard. This change allows using
> the QEMU headers with a C++ compiler.
> 
> Google-Bug-Id: 331190993
> Change-Id: I5a064853429f627c17a9213910811dea4ced6174
> Signed-off-by: Roman Kiryanov <rkir@google.com>

Would it work instead to declare MemoryRegionCache's ptr field as char*?

Thanks,

Paolo



  parent reply	other threads:[~2024-06-20 18:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-18 22:46 [PATCH 3/3] exec: use char* for pointer arithmetic Roman Kiryanov
2024-06-18 23:05 ` Richard Henderson
2024-06-19  0:09   ` Roman Kiryanov
2024-06-19  8:05   ` Daniel P. Berrangé
2024-06-20 15:10     ` Alex Bennée
2024-06-20 16:23       ` Roman Kiryanov
2024-06-20 19:09         ` Peter Maydell
2024-06-20 20:23           ` Roman Kiryanov
2024-06-20 18:06 ` Paolo Bonzini [this message]
2024-06-20 18:14   ` Richard Henderson
2024-06-20 18:16     ` Paolo Bonzini
2024-06-20 18:27       ` Roman Kiryanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b3d0472-8b06-403a-9ab8-553aa858fb7f@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=jansene@google.com \
    --cc=jpcottin@google.com \
    --cc=mett@google.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rkir@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).