From: Richard Henderson <richard.henderson@linaro.org>
To: frank.chang@sifive.com, qemu-devel@nongnu.org, qemu-riscv@nongnu.org
Cc: Chih-Min Chao <chihmin.chao@sifive.com>,
Bin Meng <bin.meng@windriver.com>,
Alistair Francis <alistair.francis@wdc.com>,
Palmer Dabbelt <palmer@dabbelt.com>
Subject: Re: [PATCH v3 2/2] target/riscv: change the api for single/double fmin/fmax
Date: Fri, 15 Oct 2021 10:05:50 -0700 [thread overview]
Message-ID: <4b718269-b222-c08f-ca72-656bacc31331@linaro.org> (raw)
In-Reply-To: <20211015065500.3850513-3-frank.chang@sifive.com>
On 10/14/21 11:54 PM, frank.chang@sifive.com wrote:
> From: Chih-Min Chao<chihmin.chao@sifive.com>
>
> The sNaN propagation behavior has been changed since
> cd20cee7 inhttps://github.com/riscv/riscv-isa-manual
>
> Signed-off-by: Chih-Min Chao<chihmin.chao@sifive.com>
> ---
> target/riscv/fpu_helper.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/target/riscv/fpu_helper.c b/target/riscv/fpu_helper.c
> index 8700516a14c..1472ead2528 100644
> --- a/target/riscv/fpu_helper.c
> +++ b/target/riscv/fpu_helper.c
> @@ -174,14 +174,14 @@ uint64_t helper_fmin_s(CPURISCVState *env, uint64_t rs1, uint64_t rs2)
> {
> float32 frs1 = check_nanbox_s(rs1);
> float32 frs2 = check_nanbox_s(rs2);
> - return nanbox_s(float32_minnum(frs1, frs2, &env->fp_status));
> + return nanbox_s(float32_minnum_noprop(frs1, frs2, &env->fp_status));
> }
Don't you need to conditionalize behaviour on the isa revision?
r~
next prev parent reply other threads:[~2021-10-15 17:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 6:54 [PATCH RESEND v3 0/2] add APIs to handle alternative sNaN propagation for fmax/fmin frank.chang
2021-10-15 6:54 ` [PATCH v3 1/2] softfloat: " frank.chang
2021-10-15 17:00 ` Richard Henderson
2021-10-16 8:51 ` Frank Chang
2021-10-15 6:54 ` [PATCH v3 2/2] target/riscv: change the api for single/double fmin/fmax frank.chang
2021-10-15 17:05 ` Richard Henderson [this message]
2021-10-16 8:52 ` Frank Chang
2021-10-16 17:56 ` Richard Henderson
2021-10-17 0:55 ` Frank Chang
2021-10-17 6:57 ` Frank Chang
2021-10-18 0:18 ` Alistair Francis
2021-10-18 3:51 ` Frank Chang
-- strict thread matches above, loose matches on Subject: below --
2021-10-15 6:11 [PATCH v3 1/2] softfloat: add APIs to handle alternative sNaN propagation for fmax/fmin frank.chang
2021-10-15 6:11 ` [PATCH v3 2/2] target/riscv: change the api for single/double fmin/fmax frank.chang
2021-10-15 6:52 ` Frank Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b718269-b222-c08f-ca72-656bacc31331@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=bin.meng@windriver.com \
--cc=chihmin.chao@sifive.com \
--cc=frank.chang@sifive.com \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).