From: Paolo Bonzini <pbonzini@redhat.com>
To: Max Reitz <mreitz@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org
Cc: fam@euphon.net, kwolf@redhat.com, jsnow@redhat.com,
qemu-devel@nongnu.org, den@openvz.org
Subject: Re: [Qemu-devel] [PATCH for-4.1] util/hbitmap: update orig_size on truncate
Date: Mon, 5 Aug 2019 16:50:28 +0200 [thread overview]
Message-ID: <4b773e90-157e-8e2b-b890-6b1ad5e0edd2@redhat.com> (raw)
In-Reply-To: <95578562-dd2a-08f2-2a00-d5f5ec723ebe@redhat.com>
On 05/08/19 14:19, Max Reitz wrote:
> On 05.08.19 14:01, Vladimir Sementsov-Ogievskiy wrote:
>> Without this, hbitmap_next_zero and hbitmap_next_dirty_area are broken
>> after truncate. So, orig_size is broken since it's introduction in
>> 76d570dc495c56bb.
>>
>> Fixes: 76d570dc495c56bb
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>> ---
>>
>> Hi!
>>
>> Here is one more hbitmap bug I noticed. It's my fault, I'm sorry :(
>> Broken in 4.0, but if we are already going to fix in 4.1 some things
>> around it, it's a small meaningful addition.
>
> Hm. :-/
>
>> Users of broken API are incremental backup, sync mirror (but it may not
>> be broken, if truncates not allowed during mirror, are they?),
>
> It doesn’t appear that way (we don’t share BLK_PERM_RESIZE).
>
>> bitmap export through NBD.
>
> I suppose that counts as block-y enough for me to take it. Well, I’d
> still like a test case to see the impact... I’ll see whether I can come
> up with something.
And also a unit test...
Paolo
next prev parent reply other threads:[~2019-08-05 14:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 12:01 [Qemu-devel] [PATCH for-4.1] util/hbitmap: update orig_size on truncate Vladimir Sementsov-Ogievskiy
2019-08-05 12:19 ` Max Reitz
2019-08-05 14:50 ` Paolo Bonzini [this message]
2019-08-05 15:38 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b773e90-157e-8e2b-b890-6b1ad5e0edd2@redhat.com \
--to=pbonzini@redhat.com \
--cc=den@openvz.org \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).