From: Thomas Huth <thuth@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>, qemu-devel@nongnu.org
Cc: rth@twiddle.net, agraf@suse.de, borntraeger@de.ibm.com
Subject: Re: [Qemu-devel] [PATCH] s390x/tcg: specification exception for unknown diag
Date: Fri, 18 Aug 2017 13:26:15 +0200 [thread overview]
Message-ID: <4b80d965-d162-84eb-c6c6-0adb86d83ce8@redhat.com> (raw)
In-Reply-To: <20170818110015.25310-1-cohuck@redhat.com>
On 18.08.2017 13:00, Cornelia Huck wrote:
> While the PoP is silent on the issue, z/VM documentation states
> that unknown diagnose codes trigger a specification exception.
> We already do that when running with kvm, so change tcg to do so
> as well.
I just tried on a z/VM guest what happens if I call diag with an
unsupported code, and the Linux kernel then crashes with a specification
exception, indeed. So this sounds like the right thing to do!
> This is on top of "s390x: wire up diag288 in tcg".
May I suggest to order the patches the other way round? ... that's less
code churn that way.
Thomas
next prev parent reply other threads:[~2017-08-18 11:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 11:00 [Qemu-devel] [PATCH] s390x/tcg: specification exception for unknown diag Cornelia Huck
2017-08-18 11:26 ` Thomas Huth [this message]
2017-08-18 11:32 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b80d965-d162-84eb-c6c6-0adb86d83ce8@redhat.com \
--to=thuth@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).