From: Paolo Bonzini <pbonzini@redhat.com>
To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [PATCH v2 05/18] ui/vc: console-vc requires PIXMAN
Date: Tue, 19 Sep 2023 14:54:24 +0200 [thread overview]
Message-ID: <4b890258-3426-0e0f-dd65-6114b9bee5e3@redhat.com> (raw)
In-Reply-To: <20230918135206.2739222-6-marcandre.lureau@redhat.com>
On 9/18/23 15:51, marcandre.lureau@redhat.com wrote:
> return "vc:80Cx24C";
> +#else
> + return "null";
Maybe return NULL and then add some heuristics in vl.c:
const char *vc = qemu_display_get_vc(&dpy);
if (nographic ||
(!vc && !is_daemonized() && isatty(STDOUT_FILENO)) {
...
} else {
if (default_serial)
add_device_config(DEV_SERIAL, vc ? vc : "null");
if (default_parallel)
add_device_config(DEV_PARALLEL, vc ? vc : "null");
if (default_monitor && vc)
monitor_parse(vc, "readline", false);
}
This would use a muxed console on stdio if pixman is disabled.
Paolo
next prev parent reply other threads:[~2023-09-19 12:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 13:51 [PATCH v2 00/18] Make Pixman an optional dependency marcandre.lureau
2023-09-18 13:51 ` [PATCH v2 01/18] build-sys: add a "pixman" feature marcandre.lureau
2023-09-19 12:43 ` Paolo Bonzini
2023-09-18 13:51 ` [PATCH v2 02/18] ui: compile out some qemu-pixman functions when !PIXMAN marcandre.lureau
2023-09-18 13:51 ` [PATCH v2 03/18] ui: add pixman-compat.h marcandre.lureau
2023-09-18 13:51 ` [PATCH v2 04/18] ui/console: allow to override the default VC marcandre.lureau
2023-09-18 13:51 ` [PATCH v2 05/18] ui/vc: console-vc requires PIXMAN marcandre.lureau
2023-09-19 12:54 ` Paolo Bonzini [this message]
2023-09-18 13:51 ` [PATCH v2 06/18] qmp/hmp: disable screendump if PIXMAN is missing marcandre.lureau
2023-09-18 13:51 ` [PATCH v2 07/18] virtio-gpu: replace PIXMAN for region/rect test marcandre.lureau
2023-09-18 13:51 ` [PATCH v2 08/18] ui/console: when PIXMAN is unavailable, don't draw placeholder msg marcandre.lureau
2023-09-18 13:51 ` [PATCH v2 09/18] vhost-user-gpu: skip VHOST_USER_GPU_UPDATE when !PIXMAN marcandre.lureau
2023-09-19 12:56 ` Paolo Bonzini
2023-09-19 13:02 ` Marc-André Lureau
2023-09-18 13:51 ` [PATCH v2 10/18] ui/gl: opengl doesn't require PIXMAN marcandre.lureau
2023-09-18 13:51 ` [PATCH v2 11/18] ui/vnc: VNC requires PIXMAN marcandre.lureau
2023-09-18 13:51 ` [PATCH v2 12/18] ui/spice: SPICE/QXL " marcandre.lureau
2023-09-18 13:52 ` [PATCH v2 13/18] ui/gtk: -display gtk " marcandre.lureau
2023-09-18 13:52 ` [PATCH v2 14/18] ui/dbus: do not require PIXMAN marcandre.lureau
2023-09-18 13:52 ` [PATCH v2 15/18] arm/kconfig: XLNX_ZYNQMP_ARM depends on PIXMAN marcandre.lureau
2023-09-18 13:52 ` [PATCH v2 16/18] hw/sm501: allow compiling without PIXMAN marcandre.lureau
2023-09-18 17:58 ` BALATON Zoltan
2023-10-10 7:34 ` Marc-André Lureau
2023-10-10 9:52 ` BALATON Zoltan
2023-10-10 10:00 ` Marc-André Lureau
2023-10-10 10:09 ` BALATON Zoltan
2023-10-10 10:12 ` Marc-André Lureau
2023-10-10 10:24 ` BALATON Zoltan
2023-09-18 13:52 ` [PATCH v2 17/18] hw/display: make ATI_VGA depend on PIXMAN marcandre.lureau
2023-09-18 13:52 ` [PATCH v2 18/18] build-sys: make pixman actually optional marcandre.lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b890258-3426-0e0f-dd65-6114b9bee5e3@redhat.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).