qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: laurent@vivier.eu, iii@linux.ibm.com,
	richard.purdie@linuxfoundation.org,  mjt@tls.msk.ru
Subject: Re: [PATCH 2/3] linux-user: Add strace for shmat
Date: Thu, 22 Feb 2024 20:04:58 -1000	[thread overview]
Message-ID: <4bcc5abb-9b42-4687-9a8d-d9c15598b11f@linaro.org> (raw)
In-Reply-To: <20240223030309.458451-3-richard.henderson@linaro.org>

On 2/22/24 17:03, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   linux-user/strace.c    | 23 +++++++++++++++++++++++
>   linux-user/strace.list |  2 +-
>   2 files changed, 24 insertions(+), 1 deletion(-)
> 
> diff --git a/linux-user/strace.c b/linux-user/strace.c
> index cf26e55264..47d6ec3263 100644
> --- a/linux-user/strace.c
> +++ b/linux-user/strace.c
> @@ -670,6 +670,25 @@ print_semctl(CPUArchState *cpu_env, const struct syscallname *name,
>   }
>   #endif
>   
> +static void
> +print_shmat(CPUArchState *cpu_env, const struct syscallname *name,
> +            abi_long arg0, abi_long arg1, abi_long arg2,
> +            abi_long arg3, abi_long arg4, abi_long arg5)
> +{
> +    static const struct flags shmat_flags[] = {
> +        FLAG_GENERIC(SHM_RND),
> +        FLAG_GENERIC(SHM_REMAP),
> +        FLAG_GENERIC(SHM_RDONLY),
> +        FLAG_GENERIC(SHM_EXEC),
> +    };

Missing FLAG_END, of course.


r~


  reply	other threads:[~2024-02-23  6:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-23  3:03 [PATCH 0/3] linux-user: Rewrite target_shmat Richard Henderson
2024-02-23  3:03 ` [PATCH 1/3] linux-user/loongarch64: Remove TARGET_FORCE_SHMLBA Richard Henderson
2024-02-23  3:42   ` gaosong
2024-02-23  3:03 ` [PATCH 2/3] linux-user: Add strace for shmat Richard Henderson
2024-02-23  6:04   ` Richard Henderson [this message]
2024-02-23  3:03 ` [PATCH 3/3] linux-user: Rewrite target_shmat Richard Henderson
2024-02-23 11:35   ` Ilya Leoshkevich
2024-02-23 22:02     ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4bcc5abb-9b42-4687-9a8d-d9c15598b11f@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=iii@linux.ibm.com \
    --cc=laurent@vivier.eu \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).