From: Paolo Bonzini <pbonzini@redhat.com>
To: Ard Biesheuvel <ardb+git@google.com>, qemu-devel@nongnu.org
Cc: Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH] hw/x86: Always treat the PVH entrypoint as a 32-bit field
Date: Fri, 27 Sep 2024 14:05:33 +0200 [thread overview]
Message-ID: <4bd26d6c-1f68-43e9-ac99-b542f24676ef@redhat.com> (raw)
In-Reply-To: <20240927071950.1458596-1-ardb+git@google.com>
On 9/27/24 09:19, Ard Biesheuvel wrote:
> -
> - pvh_start_addr = *(uint32_t *)elf_note_data_addr;
> }
>
> + pvh_start_addr = *(uint32_t *)elf_note_data_addr;
I think we even want ldl_le_p(elf_note_data_addr) here? It makes no
sense to read big-endian data.
Paolo
next prev parent reply other threads:[~2024-09-27 12:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-27 7:19 [PATCH] hw/x86: Always treat the PVH entrypoint as a 32-bit field Ard Biesheuvel
2024-09-27 12:05 ` Paolo Bonzini [this message]
2024-09-27 13:24 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bd26d6c-1f68-43e9-ac99-b542f24676ef@redhat.com \
--to=pbonzini@redhat.com \
--cc=ardb+git@google.com \
--cc=ardb@kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).