From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DEC3C433DF for ; Wed, 10 Jun 2020 08:26:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 282A72064C for ; Wed, 10 Jun 2020 08:26:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="exHCliCG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 282A72064C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55892 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiw4J-0005YA-Be for qemu-devel@archiver.kernel.org; Wed, 10 Jun 2020 04:26:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37682) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiw3d-0004tU-J6 for qemu-devel@nongnu.org; Wed, 10 Jun 2020 04:26:01 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:40786 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jiw3c-0003PL-SN for qemu-devel@nongnu.org; Wed, 10 Jun 2020 04:26:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591777559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=oV4aIS04GoiNjBtpG/mJnn+kz3ZwTWRKkLnc+jRolWA=; b=exHCliCGFlp85qAxsWvfDQl6NYeHxG8r7gAHZFf7nAXFlXZRB7Ygx2DXCY5VPFIYLUp0nu Tqhfav9AazrxT56jHG9Mkx8liCi/1FPpSLRosbatedja0eBldZOo8NsGb2BtXPh2iMyV8w lKHkYYaSJfcpknKxwTml+jkoX7YCjis= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-162-8IUdpF6pOQ-UUfhwPetyMw-1; Wed, 10 Jun 2020 04:25:53 -0400 X-MC-Unique: 8IUdpF6pOQ-UUfhwPetyMw-1 Received: by mail-wm1-f71.google.com with SMTP id y15so201827wmi.0 for ; Wed, 10 Jun 2020 01:25:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=oV4aIS04GoiNjBtpG/mJnn+kz3ZwTWRKkLnc+jRolWA=; b=J6SC3xLvUsdlpfkxLUsNHbpN3To2/xkAZVpz513EzhwNgvOTOgsnj7CtIj8aLFW8vr ogez2oRm5Wp/8ECWhCAaGL8C0U2NQBzs36fxMqEivOZrRPt9zGN2B1Vif10yUZzjMMdq RQoyXCfCQPFNxtUCjw9bLMs0uaSAdawPUF2sPsQsLzO9Dd4aOJ/D7Pori9UFWmTTqZw3 Mn0gQ706rje7Vl+ahFeKtlhONPbkWqD6aYMAbfDEcj+6h87+nH1Cfrz4vCztomD3RoZs IPYnXKEZqITFxy5nx3G/wk1PA+vfC76S3fZ4gUiWqTPZ+PVw3nC54Iuaokh1SYRhDs1A vB9A== X-Gm-Message-State: AOAM532P2S2tLDISsSGuqyaCZ7yIwq1W7YS3SPY+RCdLmRvu2AA3/YIt 2eKG4Fs5G09MenJLmyTNEN+cwsjEtdOpXEZ07boWPrKGyLETRqSTQO6QtIm/I8WOkFcnJLL1tP2 bBRtas3xDtZJdBy0= X-Received: by 2002:a5d:6288:: with SMTP id k8mr2219736wru.94.1591777552286; Wed, 10 Jun 2020 01:25:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzB3JzyVXRIsF5DkHtJ5nG11o2YNcvPyLch4iekVL1JH8mqdi1HKrAr/E+VRfIXQVU7upiKUg== X-Received: by 2002:a5d:6288:: with SMTP id k8mr2219722wru.94.1591777552088; Wed, 10 Jun 2020 01:25:52 -0700 (PDT) Received: from [192.168.1.38] (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id a15sm7266922wra.86.2020.06.10.01.25.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jun 2020 01:25:51 -0700 (PDT) Subject: Re: [PATCH] hw/vfio/pci-quirks: Fix broken legacy IGD passthrough To: Thomas Huth , Alex Williamson , qemu-devel@nongnu.org References: <20200610035102.20192-1-thuth@redhat.com> <706060db-46c4-2dee-d746-eba24e6b137d@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: <4bdc918a-a59c-a877-680a-2925c09fc736@redhat.com> Date: Wed, 10 Jun 2020 10:25:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=205.139.110.61; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/09 23:51:15 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/10/20 9:59 AM, Thomas Huth wrote: > On 10/06/2020 09.53, Philippe Mathieu-Daudé wrote: >> On 6/10/20 9:50 AM, Thomas Huth wrote: >>> On 10/06/2020 09.31, Philippe Mathieu-Daudé wrote: >>>> On 6/10/20 5:51 AM, Thomas Huth wrote: >>>>> The #ifdef CONFIG_VFIO_IGD in pci-quirks.c is not working since the >>>>> required header config-devices.h is not included, so that the legacy >>>>> IGD passthrough is currently broken. Let's include the right header >>>>> to fix this issue. >>>>> >>>>> Buglink: https://bugs.launchpad.net/qemu/+bug/1882784 >>>>> Fixes: 29d62771c81d8fd244a67c14a1d968c268d3fb19 >>>>> ("hw/vfio: Move the IGD quirk code to a separate file") >>>> >>>> What about shorter tag? >>>> >>>> Fixes: 29d62771c81 ("vfio: Move the IGD quirk code to a separate file") >>> >>> I always forget whether to use the short or the long version for >>> "Fixes:" ... this can hopefully be fixed (if necessary) when the patch >>> gets picked up. >>> >>>>> Signed-off-by: Thomas Huth >>>>> --- >>>>> hw/vfio/pci-quirks.c | 1 + >>>>> 1 file changed, 1 insertion(+) >>>>> >>>>> diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c >>>>> index f2155ddb1d..3158390db1 100644 >>>>> --- a/hw/vfio/pci-quirks.c >>>>> +++ b/hw/vfio/pci-quirks.c >>>>> @@ -11,6 +11,7 @@ >>>>> */ >>>>> >>>>> #include "qemu/osdep.h" >>>>> +#include "config-devices.h" >>>> >>>> I've been wondering how we can avoid that mistake in the >>>> future, but can find anything beside human review. >>> >>> I think in the long term, we should include config-devices.h in osdep.h, >>> just like config-host.h and config-target.h is already included there. >>> Everything else is just too confusing. But then we should also add a >>> mechanism to poison the switches from config-devices.h in common code... >> >> We only need it for the files under hw/, right? > > qtest.c in the main directory includes it, too. hw/ and qtests could include "hw/hw.h" instead of affecting all the codebase via "qemu/osdep.h". *but* we have qdevs in target/ too... so either we think about cleaning them, or we accept it is a lost cause (micro-architecture bits are tied with hardware) and are doomed. > >>> thus this likely needs some work and discussion of the patch first, so I >>> think we should go with this change to pci-quirks.c here first to get >>> the regression fixed ASAP. >> >> Sure, I'm not objecting that. > > Sure, I just wanted to make sure that whoever (Alex?) picks up this > patch does not wait for that other solution instead. > > Thomas >