Re: [PATCH RFC v1 1/3] vfio/pci: detect the support of dynamic MSI-X allocation

["Cédric Le Goater" <clg@redhat.com>]

[ ... ]

>>>>> --- a/hw/vfio/pci.h
>>>>> +++ b/hw/vfio/pci.h
>>>>> @@ -113,6 +113,7 @@ typedef struct VFIOMSIXInfo {
>>>>>        uint32_t table_offset;
>>>>>        uint32_t pba_offset;
>>>>>        unsigned long *pending;
>>>>> +    uint32_t irq_info_flags;
>>>>
>>>> Why not simply pull out a "noresize" bool?  Thanks,
>>>>   
>>> Will change to a bool type.
>>
>> I would simply cache the KVM flags value under VFIOMSIXInfo as you
>> did and add an helper. Both work the same but the intial proposal
>> keeps more information. This is minor.
> 
> TBH, I'd still prefer that we only store the one field we care about
> and avoid an extra helper, regardless of how simple it might be.  Even
> if we eventually add masking for MSI-X, we can store it in less space
> and more accessibly decoded in the VFIOMSIXInfo struct vs helpers to
> access a cached flags value.  Thanks,

Let's use a bool then. np.

Thanks,

C.