From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DF6BC433DF for ; Thu, 6 Aug 2020 11:54:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D215722CF7 for ; Thu, 6 Aug 2020 11:54:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QvJDjjj/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D215722CF7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57022 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k3cpA-00030d-6K for qemu-devel@archiver.kernel.org; Thu, 06 Aug 2020 06:08:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58662) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k3coa-0002av-Tq for qemu-devel@nongnu.org; Thu, 06 Aug 2020 06:08:00 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:45949 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k3coY-0002hx-Uy for qemu-devel@nongnu.org; Thu, 06 Aug 2020 06:08:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596708478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:openpgp:openpgp; bh=COG95HzB6W4riqDfKaT8VHOJkxpvAVw5ExvX7uBMST0=; b=QvJDjjj/4nFRuBRaGVPr0Xbi8CsNv3/ozhNjWiQCQ1BEiO1rX0/WAksDUN6e0MxEOkBXkk /aTOQE9FoCUQMus2VHry98lCigAU2xt0ZyMvtGhAUXbzoaBrjidyczCwjg+wjSAjL7Gzqz Q0rCUoGjojw/sDuOpMYbBYEHHiIy4ks= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-382-hktdH_5tPpO_aUd_doo7tw-1; Thu, 06 Aug 2020 06:07:54 -0400 X-MC-Unique: hktdH_5tPpO_aUd_doo7tw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3FA4918FF662; Thu, 6 Aug 2020 10:07:53 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-229.ams2.redhat.com [10.36.112.229]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 68D2987A4D; Thu, 6 Aug 2020 10:07:50 +0000 (UTC) Subject: Re: [PATCH 1/5] log: Add logs for vm start and destroy To: Peng Liang , qemu-trivial@nongnu.org References: <20200806093720.2355692-1-liangpeng10@huawei.com> <20200806093720.2355692-2-liangpeng10@huawei.com> From: Thomas Huth Openpgp: preference=signencrypt Message-ID: <4c171abd-1366-6ff9-f261-a450a3a1783d@redhat.com> Date: Thu, 6 Aug 2020 12:07:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200806093720.2355692-2-liangpeng10@huawei.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.139.110.61; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/06 00:07:42 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, zhang.zhanghailiang@huawei.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 06/08/2020 11.37, Peng Liang wrote: > Add logs for vm start and destroy. > > Signed-off-by: Peng Liang > --- > hw/acpi/core.c | 3 +++ > hw/core/reset.c | 2 ++ > softmmu/vl.c | 8 ++++++++ > 3 files changed, 13 insertions(+) > > diff --git a/hw/acpi/core.c b/hw/acpi/core.c > index ac06db3450..0a24f018cf 100644 > --- a/hw/acpi/core.c > +++ b/hw/acpi/core.c > @@ -560,13 +560,16 @@ static void acpi_pm1_cnt_write(ACPIREGS *ar, uint16_t val) > uint16_t sus_typ = (val >> 10) & 7; > switch(sus_typ) { > case 0: /* soft power off */ > + info_report("VM will be soft power off"); > qemu_system_shutdown_request(SHUTDOWN_CAUSE_GUEST_SHUTDOWN); > break; > case 1: > + info_report("VM will be suspend state"); > qemu_system_suspend_request(); > break; > default: > if (sus_typ == ar->pm1.cnt.s4_val) { /* S4 request */ > + info_report("VM will be S4 state"); > qapi_event_send_suspend_disk(); > qemu_system_shutdown_request(SHUTDOWN_CAUSE_GUEST_SHUTDOWN); > } There is already a trace point in qemu_system_shutdown_request(), so this can already be used instead. Thomas