Re: [PATCH] memory: Make memory_region_readd_subregion() properly handle mapped aliases

["Philippe Mathieu-Daudé" <philippe.mathieu.daude@gmail.com>]

On 1/2/22 11:09, David Hildenbrand wrote:
> memory_region_readd_subregion() wants to readd a region by first
> removing it and then readding it. For readding, it doesn't use one of
> the memory_region_add_*() variants, which is why fail to re-increment the
> mr->mapped_via_alias counters, resulting in the
> assert(alias->mapped_via_alias >= 0) in memory_region_del_subregion()
> triggering the next time we call memory_region_readd_subregion().
> 
> Fix it by using memory_region_add_subregion_common() for readding the
> region.
> 
> Reported-by: Niek Linnenbank <nieklinnenbank@gmail.com>
> Fixes: 5ead62185d23 ("memory: Make memory_region_is_mapped() succeed when mapped via an alias")
> Tested-by: Niek Linnenbank <nieklinnenbank@gmail.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Peter Xu <peterx@redhat.com>
> Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
>   softmmu/memory.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)

Thanks, queued to mips-fixes.