From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Cao Jiaxi <driver1998@foxmail.com>,
qemu-devel@nongnu.org, qemu-arm <qemu-arm@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2 3/4] util/cacheinfo.c: Use uintptr_t instead of unsigned long in AArch64 arch_cache_info()
Date: Wed, 1 May 2019 17:35:23 +0200 [thread overview]
Message-ID: <4c1ceb10-4dfa-7173-0a7e-1af919154fbd@redhat.com> (raw)
In-Reply-To: <c794f5a4-470a-3f49-c5df-bd37d97d711a@redhat.com>
On 4/30/19 9:12 PM, Philippe Mathieu-Daudé wrote:
> On 4/30/19 8:13 PM, Cao Jiaxi wrote:
>> Windows ARM64 uses LLP64 model, which breaks current assumptions.
>>
>> Signed-off-by: Cao Jiaxi <driver1998@foxmail.com>
>> ---
>> util/cacheinfo.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/util/cacheinfo.c b/util/cacheinfo.c
>> index 3cd080b83d..ce6f0dbf6a 100644
>> --- a/util/cacheinfo.c
>> +++ b/util/cacheinfo.c
>> @@ -107,7 +107,7 @@ static void sys_cache_info(int *isize, int *dsize)
>> static void arch_cache_info(int *isize, int *dsize)
>> {
>> if (*isize == 0 || *dsize == 0) {
>> - unsigned long ctr;
>> + uintptr_t ctr;
>>
>> /* The real cache geometry is in CCSIDR_EL1/CLIDR_EL1/CSSELR_EL1,
>> but (at least under Linux) these are marked protected by the
>>
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
Maybe you can use a shorter commit subject, such "util/cacheinfo: Use
uintptr_t on LLP64 model to satisfy Windows ARM64" (or better), so it
won't be cut in git log (limited to 72 chars).
next prev parent reply other threads:[~2019-05-01 15:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 18:13 [Qemu-devel] [PATCH v2 3/4] util/cacheinfo.c: Use uintptr_t instead of unsigned long in AArch64 arch_cache_info() Cao Jiaxi
2019-04-30 18:13 ` Cao Jiaxi
2019-04-30 19:12 ` Philippe Mathieu-Daudé
2019-04-30 19:12 ` Philippe Mathieu-Daudé
2019-05-01 15:35 ` Philippe Mathieu-Daudé [this message]
2019-05-01 15:35 ` Philippe Mathieu-Daudé
2019-05-02 8:26 ` Thomas Huth
2019-05-02 8:26 ` Thomas Huth
2019-05-02 16:31 ` Richard Henderson
2019-05-02 16:31 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c1ceb10-4dfa-7173-0a7e-1af919154fbd@redhat.com \
--to=philmd@redhat.com \
--cc=driver1998@foxmail.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).