From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/4] target/arm: Update hflags in trans_CPS_v7m()
Date: Tue, 3 Mar 2020 10:36:24 -0800 [thread overview]
Message-ID: <4c321c94-8b3c-3099-aea9-ab3eebc66e99@linaro.org> (raw)
In-Reply-To: <20200303174950.3298-3-peter.maydell@linaro.org>
On 3/3/20 9:49 AM, Peter Maydell wrote:
> For M-profile CPUs, the FAULTMASK value affects the CPU's MMU index
> (it changes the NegPri bit). We update the hflags after calls
> to the v7m_msr helper in trans_MSR_v7m() but forgot to do so
> in trans_CPS_v7m().
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> target/arm/translate.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2020-03-03 18:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 17:49 [PATCH 0/4] target/arm: Fix hflags mismatches for M-profile Peter Maydell
2020-03-03 17:49 ` [PATCH 1/4] hw/intc/armv7m_nvic: Rebuild hflags on reset Peter Maydell
2020-03-03 18:35 ` Richard Henderson
2020-03-03 17:49 ` [PATCH 2/4] target/arm: Update hflags in trans_CPS_v7m() Peter Maydell
2020-03-03 18:36 ` Richard Henderson [this message]
2020-03-03 17:49 ` [PATCH 3/4] target/arm: Recalculate hflags correctly after writes to CONTROL Peter Maydell
2020-03-03 18:37 ` Richard Henderson
2020-03-03 17:49 ` [PATCH 4/4] target/arm: Fix some comment typos Peter Maydell
2020-03-03 18:38 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c321c94-8b3c-3099-aea9-ab3eebc66e99@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).