Re: [Qemu-devel] [PULL V2 8/8] COLO-compare: Optimize tcp compare trace event

[Jason Wang <jasowang@redhat.com>]

On 2017年04月26日 23:55, Peter Maydell wrote:
> On 26 April 2017 at 16:18, Peter Maydell <peter.maydell@linaro.org> wrote:
>> On 25 April 2017 at 12:26, Jason Wang <jasowang@redhat.com> wrote:
>>> From: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
>>>
>>> Optimize two trace events as one, adjust print format make
>>> it easy to read. rename trace_colo_compare_pkt_info_src/dst
>>> to trace_colo_compare_tcp_info.
>>>
>>> Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
>>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>> Hi. This commit has broken building with the UST backend,
>> because it is effectively reverting commit 2dfe5113b11,
>> which split this trace line into two events because the
>> UST backend has a limit on the number of arguments that
>> a UST event can take.
>>
>> Could you revert it, please?
> ...actually it looks like it reverts cleanly on master, so
> I'll just revert it directly.
>
> thanks
> -- PMM
>

Zheng Chen, consider the UST limitation, I think we can just leave the 
two tracepoints as is (of course you can improve readability).

Thanks