From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55158) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqegw-0006Mv-Qp for qemu-devel@nongnu.org; Tue, 27 Feb 2018 07:49:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqegv-00059u-RN for qemu-devel@nongnu.org; Tue, 27 Feb 2018 07:49:10 -0500 References: <1519303376-92875-1-git-send-email-imammedo@redhat.com> <1519303376-92875-5-git-send-email-imammedo@redhat.com> From: Auger Eric Message-ID: <4c3fb706-41e8-0b2f-f2b9-25f0ef60b90d@redhat.com> Date: Tue, 27 Feb 2018 13:48:45 +0100 MIME-Version: 1.0 In-Reply-To: <1519303376-92875-5-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/9] acpi: add build_append_gas() helper for Generic Address Structure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: Peter Maydell , Andrew Jones , Shannon Zhao , qemu-arm@nongnu.org, "Michael S. Tsirkin" Hi, On 22/02/18 13:42, Igor Mammedov wrote: > it will help to add Generic Address Structure to ACPI tables > without using packed C structures and avoid endianness > issues as API doesn't need an explicit conversion. > > Signed-off-by: Igor Mammedov Reviewed-by: Eric Auger Thanks Eric > --- > include/hw/acpi/aml-build.h | 20 ++++++++++++++++++++ > hw/acpi/aml-build.c | 16 ++++++++++++++++ > 2 files changed, 36 insertions(+) > > diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h > index 88d0738..8692ccc 100644 > --- a/include/hw/acpi/aml-build.h > +++ b/include/hw/acpi/aml-build.h > @@ -78,6 +78,15 @@ typedef enum { > } AmlUpdateRule; > > typedef enum { > + AML_AS_SYSTEM_MEMORY = 0X00, > + AML_AS_SYSTEM_IO = 0X01, > + AML_AS_PCI_CONFIG = 0X02, > + AML_AS_EMBEDDED_CTRL = 0X03, > + AML_AS_SMBUS = 0X04, > + AML_AS_FFH = 0X7F, > +} AmlAddressSpace; > + > +typedef enum { > AML_SYSTEM_MEMORY = 0X00, > AML_SYSTEM_IO = 0X01, > AML_PCI_CONFIG = 0X02, > @@ -389,6 +398,17 @@ int > build_append_named_dword(GArray *array, const char *name_format, ...) > GCC_FMT_ATTR(2, 3); > > +void build_append_gas(GArray *table, AmlAddressSpace as, > + uint8_t bit_width, uint8_t bit_offset, > + uint8_t access_width, uint64_t address); > + > +static inline void > +build_append_gas_from_struct(GArray *table, const struct AcpiGenericAddress *s) > +{ > + build_append_gas(table, s->space_id, s->bit_width, s->bit_offset, > + s->access_width, s->address); > +} > + > void build_srat_memory(AcpiSratMemoryAffinity *numamem, uint64_t base, > uint64_t len, int node, MemoryAffinityFlags flags); > > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c > index 36a6cc4..3fef5f6 100644 > --- a/hw/acpi/aml-build.c > +++ b/hw/acpi/aml-build.c > @@ -258,6 +258,22 @@ static void build_append_int(GArray *table, uint64_t value) > } > } > > +/* Generic Address Structure (GAS) > + * ACPI 2.0/3.0: 5.2.3.1 Generic Address Structure > + * 2.0 compat note: > + * @access_width must be 0, see ACPI 2.0:Table 5-1 > + */ > +void build_append_gas(GArray *table, AmlAddressSpace as, > + uint8_t bit_width, uint8_t bit_offset, > + uint8_t access_width, uint64_t address) > +{ > + build_append_int_noprefix(table, as, 1); > + build_append_int_noprefix(table, bit_width, 1); > + build_append_int_noprefix(table, bit_offset, 1); > + build_append_int_noprefix(table, access_width, 1); > + build_append_int_noprefix(table, address, 8); > +} > + > /* > * Build NAME(XXXX, 0x00000000) where 0x00000000 is encoded as a dword, > * and return the offset to 0x00000000 for runtime patching. >