From: "Su Hang" <suhang16@mails.ucas.ac.cn>
To: peter maydell <peter.maydell@linaro.org>
Cc: thomas huth <thuth@redhat.com>, qemu developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] BiteSizedTasks: API conversion
Date: Mon, 12 Mar 2018 19:56:19 +0800 (GMT+08:00) [thread overview]
Message-ID: <4c423cb5.4a519.1621a1189cd.Coremail.suhang16@mails.ucas.ac.cn> (raw)
In-Reply-To: <CAFEAcA-U4_gKK744dwY1+8yRX8APSpa+7EUgNB0SW9Omfc_SGw@mail.gmail.com>
> -----Original Messages-----
> From: "Peter Maydell" <peter.maydell@linaro.org>
> Sent Time: 2018-03-12 19:40:22 (Monday)
> To: "Su Hang" <suhang16@mails.ucas.ac.cn>
> Cc: "thomas huth" <thuth@redhat.com>, "QEMU Developers" <qemu-devel@nongnu.org>
> Subject: Re: [Qemu-devel] BiteSizedTasks: API conversion
>
> On 12 March 2018 at 11:24, Su Hang <suhang16@mails.ucas.ac.cn> wrote:
> list. Any individual conversion of a callsite is probably small
> enough to be bite-sized, but you shouldn't consider "change
> everywhere" to be a single small task.)
> and I think that would be the best thing:
> (1) have address_space_write_rom() which takes the extra
> MemTxAttrs argument and returns the MemTxResult, and
> make cpu_physical_memory_write_rom() just be a trivial
> wrapper around it
> (2) then change the callers to use address_space_write_rom()
> (3) remove the cpu_physical_memory_write_rom() wrapper
>
> Step 2 is the harder part, because really it requires looking at
> the call sites to see what they should do if the memory access
> fails.
>
> thanks
> -- PMM
Thanks for your suggestion, I will work on it, step by step.
Su Hang
prev parent reply other threads:[~2018-03-12 11:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 11:24 [Qemu-devel] BiteSizedTasks: API conversion Su Hang
2018-03-12 11:40 ` Peter Maydell
2018-03-12 11:56 ` Su Hang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c423cb5.4a519.1621a1189cd.Coremail.suhang16@mails.ucas.ac.cn \
--to=suhang16@mails.ucas.ac.cn \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).