From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Pavel Dovgalyuk" <dovgaluk@ispras.ru>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH-for-5.1 v3 0/2] stubs: Fix notify-event stub linkage error on MinGW
Date: Wed, 5 Aug 2020 13:47:48 +0200 [thread overview]
Message-ID: <4c4305d4-9601-1efc-8ae9-c1b01b18ceb2@redhat.com> (raw)
In-Reply-To: <20200805100126.25583-1-philmd@redhat.com>
On 05/08/2020 12.01, Philippe Mathieu-Daudé wrote:
> 2 trivial patches to fix the link error reported by Thomas:
>
> LINK tests/test-timed-average.exe
> libqemuutil.a(main-loop.o): In function `qemu_notify_event':
> util/main-loop.c:139: multiple definition of `qemu_notify_event'
> tests/test-timed-average.o:/builds/huth/qemu/tests/../stubs/notify-event.c:5: first defined here
> collect2: error: ld returned 1 exit status
> rules.mak:124: recipe for target 'tests/test-timed-average.exe' failed
>
> Since v2:
> - Remove incorrectly added abort() in qemu_timer_notify_cb()
Works for me (tested here:
https://gitlab.com/huth/qemu/-/pipelines/174503835 ) ... but I wonder
whether there is a code path that uses the stub from
stubs/cpu-get-icount.c but the qemu_notify_event() from util/main-loop.c ?
Thomas
prev parent reply other threads:[~2020-08-05 11:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 10:01 [PATCH-for-5.1 v3 0/2] stubs: Fix notify-event stub linkage error on MinGW Philippe Mathieu-Daudé
2020-08-05 10:01 ` [PATCH-for-5.1 v3 1/2] exec: Restrict icount to softmmu Philippe Mathieu-Daudé
2020-08-05 10:12 ` Claudio Fontana
2020-08-05 10:45 ` Philippe Mathieu-Daudé
2020-08-05 16:08 ` Richard Henderson
2020-08-05 10:01 ` [PATCH-for-5.1 v3 2/2] stubs: Remove qemu_notify_event() Philippe Mathieu-Daudé
2020-08-05 11:47 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c4305d4-9601-1efc-8ae9-c1b01b18ceb2@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).