From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0818AC433DF for ; Wed, 5 Aug 2020 11:48:47 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C94D622D05 for ; Wed, 5 Aug 2020 11:48:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="i3pZNUHr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C94D622D05 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45848 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k3HuX-0002eu-Up for qemu-devel@archiver.kernel.org; Wed, 05 Aug 2020 07:48:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40738) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k3Hto-0002GS-0K for qemu-devel@nongnu.org; Wed, 05 Aug 2020 07:48:00 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:27105 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k3Htl-0006c1-LO for qemu-devel@nongnu.org; Wed, 05 Aug 2020 07:47:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596628076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:openpgp:openpgp; bh=7cToy/1IPQ7gTBQAmDa7gJTx2xZqaLFyoMhnUPo9iJA=; b=i3pZNUHrzaAYMkxBcb6omoIC48fKs7ph1O+tmMw39tvqY+AGufMUBV1gNJBsyI/FPXtqem kg3KVhc/2CH5SHSSoaTvlqMqk6/c4zAmlAiNJUSVQQ7kZm3iIBPcfrGq6+nUMg9w3eEBYH onZRs3be5zvqsQt8WxjZ9rJYxgY2Q1I= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-86-7UFpv9-XPFmuWZou_bEjEg-1; Wed, 05 Aug 2020 07:47:54 -0400 X-MC-Unique: 7UFpv9-XPFmuWZou_bEjEg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5889A80183C; Wed, 5 Aug 2020 11:47:53 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-142.ams2.redhat.com [10.36.112.142]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DE9865C1BD; Wed, 5 Aug 2020 11:47:50 +0000 (UTC) Subject: Re: [PATCH-for-5.1 v3 0/2] stubs: Fix notify-event stub linkage error on MinGW To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org, Paolo Bonzini References: <20200805100126.25583-1-philmd@redhat.com> From: Thomas Huth Openpgp: preference=signencrypt Message-ID: <4c4305d4-9601-1efc-8ae9-c1b01b18ceb2@redhat.com> Date: Wed, 5 Aug 2020 13:47:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200805100126.25583-1-philmd@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=205.139.110.120; envelope-from=thuth@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/05 00:45:55 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Alex_Benn=c3=a9e?= , Richard Henderson , Pavel Dovgalyuk , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 05/08/2020 12.01, Philippe Mathieu-Daudé wrote: > 2 trivial patches to fix the link error reported by Thomas: > > LINK tests/test-timed-average.exe > libqemuutil.a(main-loop.o): In function `qemu_notify_event': > util/main-loop.c:139: multiple definition of `qemu_notify_event' > tests/test-timed-average.o:/builds/huth/qemu/tests/../stubs/notify-event.c:5: first defined here > collect2: error: ld returned 1 exit status > rules.mak:124: recipe for target 'tests/test-timed-average.exe' failed > > Since v2: > - Remove incorrectly added abort() in qemu_timer_notify_cb() Works for me (tested here: https://gitlab.com/huth/qemu/-/pipelines/174503835 ) ... but I wonder whether there is a code path that uses the stub from stubs/cpu-get-icount.c but the qemu_notify_event() from util/main-loop.c ? Thomas