From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=38443 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OglCQ-0003Qw-By
	for qemu-devel@nongnu.org; Wed, 04 Aug 2010 17:08:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <aaron.mason@thats-too-much.info>) id 1OglCL-0003Gr-Ug
	for qemu-devel@nongnu.org; Wed, 04 Aug 2010 17:08:30 -0400
Received: from mail-wy0-f173.google.com ([74.125.82.173]:63934)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <aaron.mason@thats-too-much.info>) id 1OglCL-0003GY-Qn
	for qemu-devel@nongnu.org; Wed, 04 Aug 2010 17:08:25 -0400
Received: by wyi11 with SMTP id 11so226318wyi.4
	for <qemu-devel@nongnu.org>; Wed, 04 Aug 2010 14:08:24 -0700 (PDT)
Message-ID: <4c59d6c5.258ed80a.282a.037f@mx.google.com>
MIME-Version: 1.0
content-class: 
From: Aaron Mason <aaron.mason@thats-too-much.info>
Subject: RE: [Qemu-devel] [PATCH] Added an option to set the VMDK adapter type
Date: Thu, 5 Aug 2010 07:07:54 +1000
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>, andrzej zaborowski <balrogg@gmail.com>
Cc: qemu-devel@nongnu.org

there

sent from my Telstra NEXTG=E2=84=A2 handset

-----Original Message-----
From: Kevin Wolf <kwolf@redhat.com>
Sent: Wednesday, 4 August 2010 10:29 PM
To: andrzej zaborowski <balrogg@gmail.com>
Cc: Aaron Mason <aaron.mason@thats-too-much.info>; qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Added an option to set the VMDK adapter t=
ype

Am 04.08.2010 14:27, schrieb andrzej zaborowski:
> Hi,
>=20
> On 4 August 2010 12:30, Kevin Wolf <kwolf@redhat.com> wrote:
>> Am 04.08.2010 01:46, schrieb Aaron Mason:
>>> +    const char *real_filename, *temp_str, *adapterType =3D "ide";
>=20
> Sorry to complain about style, but note that uppercase characters are
> not used in variable names in Qemu (that I see).

Whoops, missed that one when complaining about the other style problems.
Yes, this should be adapter_type.

Kevin