From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A59D9C433E0 for ; Wed, 10 Feb 2021 11:31:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2E3764DF2 for ; Wed, 10 Feb 2021 11:31:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2E3764DF2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9niW-0003Du-Tc for qemu-devel@archiver.kernel.org; Wed, 10 Feb 2021 06:31:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9nhJ-0002gi-Ms for qemu-devel@nongnu.org; Wed, 10 Feb 2021 06:30:17 -0500 Received: from mx2.suse.de ([195.135.220.15]:48140) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9nhH-0002zx-Gc for qemu-devel@nongnu.org; Wed, 10 Feb 2021 06:30:17 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BE6A9ACB7; Wed, 10 Feb 2021 11:30:12 +0000 (UTC) Subject: Re: [PATCH v16 19/23] i386: split cpu accelerators from cpu.c, using AccelCPUClass To: Richard Henderson , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Paolo Bonzini , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Eduardo Habkost , Peter Maydell References: <20210204163931.7358-1-cfontana@suse.de> <20210204163931.7358-20-cfontana@suse.de> <8586d6a7-7b68-754c-11c3-39e30c27e28d@linaro.org> From: Claudio Fontana Message-ID: <4c6b2706-c9e9-bf9c-400f-c897783b3cf9@suse.de> Date: Wed, 10 Feb 2021 12:30:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <8586d6a7-7b68-754c-11c3-39e30c27e28d@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-Spam_score_int: -44 X-Spam_score: -4.5 X-Spam_bar: ---- X-Spam_report: (-4.5 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.265, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Alistair Francis , Roman Bolshakov , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Ciao Paolo, On 2/5/21 9:04 PM, Richard Henderson wrote: > On 2/4/21 6:39 AM, Claudio Fontana wrote: >> +static void hvf_cpu_accel_class_init(ObjectClass *oc, void *data) >> +{ >> + AccelCPUClass *acc = ACCEL_CPU_CLASS(oc); >> + >> + acc->cpu_realizefn = host_cpu_realizefn; >> + acc->cpu_instance_init = hvf_cpu_instance_init; >> +}; > > Watch the stray ; after functions. Thanks Richard, removed. > Make sure there's a blank line in between functions and file-scope structure > definitions. I'll keep an eye on it, let me know if you see an example in this or other patches. > >> +static const TypeInfo hvf_cpu_accel_type_info = { >> + .name = ACCEL_CPU_NAME("hvf"), >> + >> + .parent = TYPE_ACCEL_CPU, >> + .class_init = hvf_cpu_accel_class_init, >> + .abstract = true, >> +}; >> +static void hvf_cpu_accel_register_types(void) >> +{ >> + type_register_static(&hvf_cpu_accel_type_info); >> +} > > The rest looks ok, but I would like to see other i386 review. Thanks, maybe Paolo could help? It's just code shuffling, but of course a mistake is always possible. Claudio