Re: [PATCH v3 1/4] python: Install pygdbmi in venv

[Thomas Huth <thuth@redhat.com>]

On 22/09/2025 07.43, Gustavo Romero wrote:
> Install pygdbmi in Meson's venv. pygdbmi is required by functional tests
> that interact with GDB. pygdbmi size is only 21 kB.
> 
> The wheel file has been obtained with:
> 
> pyvenv/bin/pip3 download --only-binary :all: --dest . --no-cache pygdbmi
> 
> Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
> ---
>   python/wheels/pygdbmi-0.11.0.0-py3-none-any.whl | Bin 0 -> 21258 bytes
>   pythondeps.toml                                 |   1 +
>   2 files changed, 1 insertion(+)
>   create mode 100644 python/wheels/pygdbmi-0.11.0.0-py3-none-any.whl

I think we should rather avoid to add python test dependencies as wheels 
(unless it's really necessary as it was with the pycotap module that is also 
required for the "quick" tests).

It's better if we finally re-activate the "check-venv" target for the 
functional tests (we used it in the past for the avocado-based tests, too).

Could you please try whether something like this does the job for you:

diff --git a/pythondeps.toml b/pythondeps.toml
--- a/pythondeps.toml
+++ b/pythondeps.toml
@@ -33,3 +33,4 @@ sphinx_rtd_theme = { accepted = ">=0.5", installed = "1.2.2" }

  [testdeps]
  qemu.qmp = { accepted = ">=0.0.3", installed = "0.0.3" }
+pygdbmi = { accepted = ">=0.11.0.0", installed = "0.11.0.0" }
diff --git a/tests/Makefile.include b/tests/Makefile.include
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -109,7 +109,7 @@ $(FUNCTIONAL_TARGETS):
         @$(MAKE) SPEED=thorough $(subst -functional,-func,$@)

  .PHONY: check-functional
-check-functional:
+check-functional: check-venv
         @$(NINJA) precache-functional
         @QEMU_TEST_NO_DOWNLOAD=1 $(MAKE) SPEED=thorough check-func 
check-func-quick


?

  Thanks,
   Thomas