From: David Hildenbrand <david@redhat.com>
To: Collin Walling <walling@linux.ibm.com>,
Markus Armbruster <armbru@redhat.com>
Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org, thuth@redhat.com,
wangyanan55@huawei.com, philmd@linaro.org,
marcel.apfelbaum@gmail.com, eduardo@habkost.net
Subject: Re: [PATCH v1] target/s390x: move @deprecated-props to CpuModelExpansion Info
Date: Mon, 29 Jul 2024 21:48:14 +0200 [thread overview]
Message-ID: <4c99a6a4-77f3-4661-8d16-8a8cd59b1113@redhat.com> (raw)
In-Reply-To: <4f617078-e88d-4006-a56b-6bed684e577b@linux.ibm.com>
>
>> + bitmap_zero(deprecated_feats, S390_FEAT_MAX);
>> + s390_get_deprecated_features(deprecated_feats);
>> +
>> + if (delta_changes) {
>> + /*
>> + * Only populate deprecated features that are a
>> + * subset of the features enabled on the CPU model.
>> + */
>> + bitmap_and(deprecated_feats, deprecated_feats,
>> + s390_model.features, S390_FEAT_MAX);
>> + }
>> +
>> + s390_feat_bitmap_to_ascii(deprecated_feats,
>> + &expansion_info->deprecated_props, list_add_feat);
>> return expansion_info;
>> }
>>
>
> Eh, just a small nit above due to a typo I made. Other than that, gave
> it all another run-through just in case and everything is still good.
>
Fixed up, thanks!
--
Cheers,
David / dhildenb
prev parent reply other threads:[~2024-07-29 19:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-26 20:36 [PATCH v1] target/s390x: move @deprecated-props to CpuModelExpansion Info Collin Walling
2024-07-26 21:16 ` David Hildenbrand
2024-07-26 22:38 ` Collin Walling
2024-07-27 6:02 ` Markus Armbruster
2024-07-29 9:52 ` David Hildenbrand
2024-07-29 14:15 ` Markus Armbruster
2024-07-29 14:22 ` David Hildenbrand
2024-07-29 14:36 ` Markus Armbruster
2024-07-29 14:49 ` Collin Walling
2024-07-29 15:24 ` David Hildenbrand
2024-07-29 19:25 ` Collin Walling
2024-07-29 19:48 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c99a6a4-77f3-4661-8d16-8a8cd59b1113@redhat.com \
--to=david@redhat.com \
--cc=armbru@redhat.com \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
--cc=walling@linux.ibm.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).