From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46E03C433FE for ; Fri, 4 Dec 2020 20:43:39 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AFFE822CB1 for ; Fri, 4 Dec 2020 20:43:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AFFE822CB1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51496 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1klHvV-0003Ux-JL for qemu-devel@archiver.kernel.org; Fri, 04 Dec 2020 15:43:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59162) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klHST-0001QF-Oy for qemu-devel@nongnu.org; Fri, 04 Dec 2020 15:13:37 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:60601) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1klHSR-0003ur-9B for qemu-devel@nongnu.org; Fri, 04 Dec 2020 15:13:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607112812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vq8zwhf+uq/yvlz7BH5BqxVblHZ0SQi5WY63CNMnBZU=; b=incRbXAzOD4wHvL8aQoP0DbbI1MHogPZQTdqS4t6kHFMtg6MfcUxm3bRgPIgK2Ivj9DWFr ++kOcWDNGUDy0zcl5rh9vMNT7lg/0R03uhFWaa8Ljn/IuCcNN5miKLnJ6iTQa2QS1oeTRC xry+tkdBXKdkvj5THcAoaElMlZmeVEg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-551-A62JKymYOa23XBiKPRR9sQ-1; Fri, 04 Dec 2020 15:13:29 -0500 X-MC-Unique: A62JKymYOa23XBiKPRR9sQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C8A99800D55; Fri, 4 Dec 2020 20:13:27 +0000 (UTC) Received: from wainer-laptop.localdomain (ovpn-114-123.rdu2.redhat.com [10.10.114.123]) by smtp.corp.redhat.com (Postfix) with ESMTP id AFF8F60C13; Fri, 4 Dec 2020 20:13:24 +0000 (UTC) Subject: Re: [PATCH v2] tests/acceptance: test hot(un)plug of ccw devices To: Cornelia Huck References: <20201204121450.120730-1-cohuck@redhat.com> <887409fe-4627-b5d7-69e1-d84560cb3999@redhat.com> <20201204150809.7a616a4e.cohuck@redhat.com> From: Wainer dos Santos Moschetta Message-ID: <4c9e76e8-54d1-068f-0567-d59bea094a34@redhat.com> Date: Fri, 4 Dec 2020 17:13:22 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201204150809.7a616a4e.cohuck@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=wainersm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Received-SPF: pass client-ip=216.205.24.124; envelope-from=wainersm@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.496, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , qemu-devel@nongnu.org, Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, Cleber Rosa , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/4/20 11:08 AM, Cornelia Huck wrote: > On Fri, 4 Dec 2020 11:05:34 -0300 > Wainer dos Santos Moschetta wrote: > >> Hi, >> >> On 12/4/20 9:14 AM, Cornelia Huck wrote: >>> Hotplug a virtio-net-ccw device, and then hotunplug it again. >>> >>> Signed-off-by: Cornelia Huck >>> --- >>> >>> v1->v2: >>> - switch device id >>> - clear out dmesg before looking for CRW messages >>> >>> --- >>> tests/acceptance/machine_s390_ccw_virtio.py | 16 ++++++++++++++++ >>> 1 file changed, 16 insertions(+) >>> >>> diff --git a/tests/acceptance/machine_s390_ccw_virtio.py b/tests/acceptance/machine_s390_ccw_virtio.py >>> index 53b8484f8f9c..83c00190621b 100644 >>> --- a/tests/acceptance/machine_s390_ccw_virtio.py >>> +++ b/tests/acceptance/machine_s390_ccw_virtio.py >>> @@ -97,3 +97,19 @@ class S390CCWVirtioMachine(Test): >>> exec_command_and_wait_for_pattern(self, >>> 'cat /sys/bus/pci/devices/000a\:00\:00.0/function_id', >>> '0x0000000c') >>> + # add another device >>> + exec_command_and_wait_for_pattern(self, 'dmesg -c', ' ') >> >> The problem is that `dmesg -c` will fail if you run the test with >> unprivileged user. > Hm, why should that make a difference for a guest command? Never mind, my brain mix host and guest very often.... Reviewed-by: Wainer dos Santos Moschetta > >> - Wainer >> >>> + self.vm.command('device_add', driver='virtio-net-ccw', >>> + devno='fe.0.4711', id='net_4711') >>> + exec_command_and_wait_for_pattern(self, 'dmesg', 'CRW') >>> + exec_command_and_wait_for_pattern(self, 'ls /sys/bus/ccw/devices/', >>> + '0.0.4711') >>> + # and detach it again >>> + exec_command_and_wait_for_pattern(self, 'dmesg -c', ' ') >>> + self.vm.command('device_del', id='net_4711') >>> + self.vm.event_wait(name='DEVICE_DELETED', >>> + match={'data': {'device': 'net_4711'}}) >>> + exec_command_and_wait_for_pattern(self, 'dmesg', 'CRW') >>> + exec_command_and_wait_for_pattern(self, >>> + 'ls /sys/bus/ccw/devices/0.0.4711', >>> + 'No such file or directory')