From: Ninad Palsule <ninad@linux.ibm.com>
To: "Cédric Le Goater" <clg@kaod.org>,
qemu-devel@nongnu.org, peter.maydell@linaro.org,
andrew@codeconstruct.com.au, joel@jms.id.au, pbonzini@redhat.com,
marcandre.lureau@redhat.com, berrange@redhat.com,
thuth@redhat.com, philmd@linaro.org, lvivier@redhat.com
Cc: qemu-arm@nongnu.org, Andrew Jeffery <andrew@aj.id.au>
Subject: Re: [PATCH v11 05/11] hw/fsi: Introduce IBM's cfam
Date: Fri, 26 Jan 2024 04:08:29 -0600 [thread overview]
Message-ID: <4ca3ee69-55e9-4cec-a4d8-23304ff6290d@linux.ibm.com> (raw)
In-Reply-To: <6c1a24a2-dfc6-4ce3-828b-4bc196f9d71f@kaod.org>
Hello Cedric,
>> +#include "hw/fsi/fsi.h"
>> +
>> +#include "hw/qdev-properties.h"
>> +
>> +#define ENGINE_CONFIG_NEXT BE_BIT(0)
>
> BE_BIT is not used much. I wonder if we should keep it.
Agree. It is only used at couple of places. Removed BE_BIT()
>
> Anyhow,
>
>
> Reviewed-by: Cédric Le Goater <clg@kaod.org>
Added tag. Thanks for the review.
Regards,
Ninad
next prev parent reply other threads:[~2024-01-26 10:09 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 3:40 [PATCH v11 00/11] Introduce model for IBM's FSI Ninad Palsule
2024-01-26 3:40 ` [PATCH v11 01/11] hw/fsi: Introduce IBM's Local bus Ninad Palsule
2024-01-26 8:31 ` Cédric Le Goater
2024-01-26 9:48 ` Ninad Palsule
2024-01-26 3:40 ` [PATCH v11 02/11] hw/fsi: Introduce IBM's scratchpad device Ninad Palsule
2024-01-26 8:33 ` Cédric Le Goater
2024-01-26 9:54 ` Ninad Palsule
2024-01-26 3:40 ` [PATCH v11 03/11] hw/fsi: Introduce IBM's FSI Bus Ninad Palsule
2024-01-26 8:33 ` Cédric Le Goater
2024-01-26 9:56 ` Ninad Palsule
2024-01-26 3:40 ` [PATCH v11 04/11] hw/fsi: Introduce IBM's fsi-slave model Ninad Palsule
2024-01-26 8:35 ` Cédric Le Goater
2024-01-26 10:00 ` Ninad Palsule
2024-01-26 3:40 ` [PATCH v11 05/11] hw/fsi: Introduce IBM's cfam Ninad Palsule
2024-01-26 8:39 ` Cédric Le Goater
2024-01-26 10:08 ` Ninad Palsule [this message]
2024-01-26 3:40 ` [PATCH v11 06/11] hw/fsi: Introduce IBM's FSI master Ninad Palsule
2024-01-26 8:42 ` Cédric Le Goater
2024-01-26 10:10 ` Ninad Palsule
2024-01-26 3:40 ` [PATCH v11 07/11] hw/fsi: Aspeed APB2OPB & On-chip peripheral bus Ninad Palsule
2024-01-26 8:50 ` Cédric Le Goater
2024-01-26 10:14 ` Ninad Palsule
2024-01-26 3:40 ` [PATCH v11 08/11] hw/arm: Hook up FSI module in AST2600 Ninad Palsule
2024-01-26 3:40 ` [PATCH v11 09/11] hw/fsi: Added qtest Ninad Palsule
2024-01-26 3:40 ` [PATCH v11 10/11] hw/fsi: Added FSI documentation Ninad Palsule
2024-01-26 8:57 ` Cédric Le Goater
2024-01-26 10:29 ` Ninad Palsule
2024-01-26 3:40 ` [PATCH v11 11/11] hw/fsi: Update MAINTAINER list Ninad Palsule
2024-01-26 8:57 ` Cédric Le Goater
2024-01-26 10:30 ` Ninad Palsule
2024-01-26 9:00 ` [PATCH v11 00/11] Introduce model for IBM's FSI Cédric Le Goater
2024-01-26 10:30 ` Ninad Palsule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ca3ee69-55e9-4cec-a4d8-23304ff6290d@linux.ibm.com \
--to=ninad@linux.ibm.com \
--cc=andrew@aj.id.au \
--cc=andrew@codeconstruct.com.au \
--cc=berrange@redhat.com \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).