From: John Snow <jsnow@redhat.com>
To: mahaocong <mahaocong_work@163.com>, qemu-block@nongnu.org
Cc: fam@euphon.net, kwolf@redhat.com,
mahaocong <mahaocong@didichuxing.com>,
qemu-devel@nongnu.org, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v1] add new function to copy dirty-bitmap
Date: Wed, 30 Jan 2019 17:12:47 -0500 [thread overview]
Message-ID: <4ca4be78-22f9-53ed-2ca6-9592b77f46cb@redhat.com> (raw)
In-Reply-To: <20190102100113.24621-1-mahaocong_work@163.com>
On 1/2/19 5:01 AM, mahaocong wrote:
> From: mahaocong <mahaocong@didichuxing.com>
>
> This patch adds new function to copy the hbitmap from an exist dirty-bitmap to
> another. The destination bitmap should have the same size and granularity with
> the source bitmap, or the copy will fail.
>
> Signed-off-by: mahaocong <mahaocong@didichuxing.com>
/technically/ we *can* do this already by creating a blank bitmap and
merging from one bitmap to the empty one.
Do you have a good argument for why copy is needed in addition?
--js
prev parent reply other threads:[~2019-01-30 22:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 10:01 [Qemu-devel] [PATCH v1] add new function to copy dirty-bitmap mahaocong
2019-01-03 20:23 ` Eric Blake
2019-01-30 22:12 ` John Snow [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ca4be78-22f9-53ed-2ca6-9592b77f46cb@redhat.com \
--to=jsnow@redhat.com \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mahaocong@didichuxing.com \
--cc=mahaocong_work@163.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).