qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: Jeff Cody <jcody@redhat.com>, qemu-devel@nongnu.org
Cc: stefanha@redhat.com, ashmit602@gmail.com, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] block/vxhs: Allow VXHS to be built as a module
Date: Mon, 8 May 2017 13:29:46 -0400	[thread overview]
Message-ID: <4ca8dbaf-d5ce-1897-dad5-e181ec60ecdf@redhat.com> (raw)
In-Reply-To: <de25b9a195ff29f7d4bbaec5af4c2f98532d1b9c.1493933558.git.jcody@redhat.com>



On 05/04/2017 05:35 PM, Jeff Cody wrote:
> In 88d8879, protocol drivers had modularization enabled.  As VXHS is a
> protocol, make sure it is able to be built as a module as well.
> 
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 48a9370..eada141 100755
> --- a/configure
> +++ b/configure
> @@ -5859,7 +5859,7 @@ if test "$pthread_setname_np" = "yes" ; then
>  fi
>  
>  if test "$vxhs" = "yes" ; then
> -  echo "CONFIG_VXHS=y" >> $config_host_mak
> +  echo "CONFIG_VXHS=m" >> $config_host_mak
>    echo "VXHS_LIBS=$vxhs_libs" >> $config_host_mak
>  fi
>  
> 

ERROR: User requested feature vxhs block device
       configure was not able to find it.
       Install libvxhs See github

wow gee, thanks configure file. I'll go "see github."

Not actually that easy to find; separate patch, but could this be
touched up?

  reply	other threads:[~2017-05-08 17:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-04 21:34 [Qemu-devel] [PATCH 0/2] Minor VXHS fixups Jeff Cody
2017-05-04 21:35 ` [Qemu-devel] [PATCH 1/2] block/vxhs: Allow VXHS to be built as a module Jeff Cody
2017-05-08 17:29   ` John Snow [this message]
2017-05-08 17:48     ` [Qemu-devel] [Qemu-block] " Jeff Cody
2017-05-04 21:35 ` [Qemu-devel] [PATCH 2/2] block/vxhs: set errp on iio_init() failure Jeff Cody

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ca8dbaf-d5ce-1897-dad5-e181ec60ecdf@redhat.com \
    --to=jsnow@redhat.com \
    --cc=ashmit602@gmail.com \
    --cc=jcody@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).