From: Eric Blake <eblake@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
"Peter Maydell" <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH 03/11] hw/misc: add missing includes
Date: Tue, 9 May 2017 12:24:13 -0500 [thread overview]
Message-ID: <4cb5814d-d8bb-db4f-3c85-9ef245534f33@redhat.com> (raw)
In-Reply-To: <bdc0fa6a-a90c-3f7a-a37c-bc901a6022c2@amsat.org>
[-- Attachment #1: Type: text/plain, Size: 519 bytes --]
On 05/09/2017 12:20 PM, Philippe Mathieu-Daudé wrote:
> What about the other include, "hw/sysbus.h"?
> The inlined function create_unimplemented_device() calls
> sysbus_mmio_map_overlap(). Anyone willing to use "hw/misc/unimp.h" will
> get a compilation failure if he does not include "hw/sysbus.h" and I
> don't think it belongs to "qemu/osdep.h".
That one's probably okay.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-05-09 17:24 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 23:39 [Qemu-devel] [PATCH 00/11] various easy cleanups Philippe Mathieu-Daudé
2017-05-08 23:39 ` [Qemu-devel] [PATCH 01/11] hw/net: removed obsolete comments Philippe Mathieu-Daudé
2017-05-09 7:27 ` Alex Bennée
2017-05-08 23:39 ` [Qemu-devel] [RFC PATCH 02/11] hw/pci: define msi_nonbroken in pci-stub Philippe Mathieu-Daudé
2017-05-09 5:19 ` Thomas Huth
2017-05-09 16:49 ` Philippe Mathieu-Daudé
2017-05-09 18:24 ` Thomas Huth
2017-05-08 23:39 ` [Qemu-devel] [PATCH 03/11] hw/misc: add missing includes Philippe Mathieu-Daudé
2017-05-08 23:56 ` Eric Blake
2017-05-09 0:56 ` Philippe Mathieu-Daudé
2017-05-09 17:20 ` Philippe Mathieu-Daudé
2017-05-09 17:24 ` Eric Blake [this message]
2017-09-05 9:35 ` Philippe Mathieu-Daudé
2017-09-05 9:39 ` Peter Maydell
2017-05-08 23:39 ` [Qemu-devel] [PATCH 04/11] ide/ahci: " Philippe Mathieu-Daudé
2017-05-08 23:58 ` Eric Blake
2017-05-09 13:49 ` John Snow
2017-06-09 15:05 ` [Qemu-devel] [RFC PATCH 0/2] " Philippe Mathieu-Daudé
2017-06-09 15:05 ` [Qemu-devel] [RFC PATCH 1/2] arm/highbank: use defined type name instead of hard-coded string Philippe Mathieu-Daudé
2017-06-23 22:18 ` John Snow
2017-06-26 4:32 ` Philippe Mathieu-Daudé
2017-06-09 15:06 ` [Qemu-devel] [RFC PATCH 2/2] ide/ahci: add missing includes Philippe Mathieu-Daudé
2017-05-08 23:39 ` [Qemu-devel] [PATCH 05/11] hw/mips: add missing include Philippe Mathieu-Daudé
2017-05-08 23:55 ` Aurelien Jarno
2017-05-23 15:00 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2017-05-08 23:39 ` [Qemu-devel] [PATCH 06/11] hw/arm: removed unnecessary include Philippe Mathieu-Daudé
2017-05-23 14:58 ` Michael Tokarev
2017-06-09 21:28 ` Philippe Mathieu-Daudé
2017-05-08 23:39 ` [Qemu-devel] [PATCH 08/11] hw/sparc: use ARRAY_SIZE() macro Philippe Mathieu-Daudé
2017-05-09 7:25 ` Alex Bennée
2017-05-23 14:56 ` Michael Tokarev
2017-05-08 23:39 ` [Qemu-devel] [PATCH 09/11] target/sparc: fix DEBUG_MMU DPRINTF() arguments Philippe Mathieu-Daudé
2017-05-09 0:00 ` Eric Blake
2017-05-09 0:54 ` Philippe Mathieu-Daudé
2017-05-08 23:39 ` [Qemu-devel] [PATCH 10/11] register: display register prefix (name) since it is available Philippe Mathieu-Daudé
2017-05-09 0:05 ` Alistair Francis
2017-05-23 14:56 ` Michael Tokarev
2017-05-08 23:39 ` [Qemu-devel] [PATCH 11/11] MAINTAINERS: self-appoint me as reviewer of the Register API Philippe Mathieu-Daudé
2017-05-23 15:03 ` [Qemu-devel] [PATCH 00/11] various easy cleanups Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cb5814d-d8bb-db4f-3c85-9ef245534f33@redhat.com \
--to=eblake@redhat.com \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).