From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>,
qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH] tracetool: use relative paths for '#line' preprocessor directives
Date: Tue, 11 Apr 2023 12:44:14 +0200 [thread overview]
Message-ID: <4ceb989e-0df3-524c-6bd8-50f929369001@linaro.org> (raw)
In-Reply-To: <20230406080045.21696-1-thomas.de_schampheleire@nokia.com>
On 6/4/23 10:00, Thomas De Schampheleire wrote:
> The event filename is an absolute path. Convert it to a relative path when
> writing '#line' directives, to preserve reproducibility of the generated
> output when different base paths are used.
>
> Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
> ---
> scripts/tracetool/backend/ftrace.py | 4 +++-
> scripts/tracetool/backend/log.py | 4 +++-
> scripts/tracetool/backend/syslog.py | 4 +++-
> 3 files changed, 9 insertions(+), 3 deletions(-)
Nice.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
prev parent reply other threads:[~2023-04-11 10:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 8:00 [PATCH] tracetool: use relative paths for '#line' preprocessor directives Thomas De Schampheleire
2023-04-09 12:50 ` Stefan Hajnoczi
2023-04-11 10:44 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ceb989e-0df3-524c-6bd8-50f929369001@linaro.org \
--to=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thomas.de_schampheleire@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).