From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34140) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bICw6-0005wm-BR for qemu-devel@nongnu.org; Wed, 29 Jun 2016 06:41:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bICw1-0003Zz-EF for qemu-devel@nongnu.org; Wed, 29 Jun 2016 06:41:38 -0400 Sender: Paolo Bonzini References: <1466780802-30424-1-git-send-email-den@openvz.org> <1466780802-30424-3-git-send-email-den@openvz.org> <9cafd60f-ac23-863d-0225-636499904398@redhat.com> <57738838.5050708@virtuozzo.com> From: Paolo Bonzini Message-ID: <4d030713-6e2a-df41-bcd2-91611c8f7905@redhat.com> Date: Wed, 29 Jun 2016 12:41:29 +0200 MIME-Version: 1.0 In-Reply-To: <57738838.5050708@virtuozzo.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] ide: ignore retry_unit check for non-retry operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Evgeny Yakovlev , "Denis V. Lunev" , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: Kevin Wolf , John Snow , Fam Zheng , Stefan Hajnoczi , Max Reitz On 29/06/2016 10:35, Evgeny Yakovlev wrote: >>> >> Wouldn't the assertion fail for a PIO read/write too? Perhaps >> retry_unit should be set to s->unit in ide_transfer_start too. > > If PIO follows DMA and fails then yes, it looks like it will trigger an > assert. I am not sure about setting retry_unit in ide_transfer_start. It > looks like currently only DMA I/O entries touch retry_unit at all. Does > that mean that PIO, flush, etc do not support retries by design and we > need to add more exceptions to assert check or is it a real bug in how > retries are initialized? Both PIO and flush do support retries, so I think it is a real bug. Paolo