qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
	qemu-ppc@nongnu.org, "David Gibson" <david@gibson.dropbear.id.au>,
	kvm@vger.kernel.org, "Alexey Kardashevskiy" <aik@ozlabs.ru>,
	"Cédric Le Goater" <clg@kaod.org>, "Greg Kurz" <groug@kaod.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>
Subject: Re: [PATCH-for-8.0 2/4] hw/ppc/vof: Do not include the full "cpu.h"
Date: Fri, 16 Dec 2022 13:33:48 -0300	[thread overview]
Message-ID: <4d03a8c7-a7ef-cac8-9ca3-f06757131aab@gmail.com> (raw)
In-Reply-To: <20221213123550.39302-3-philmd@linaro.org>



On 12/13/22 09:35, Philippe Mathieu-Daudé wrote:
> "vof.h" doesn't need the full "cpu.h" to get the target_ulong
> definition, including "exec/cpu-defs.h" is enough.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

>   include/hw/ppc/vof.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/hw/ppc/vof.h b/include/hw/ppc/vof.h
> index f8c0effcaf..d3f293da8b 100644
> --- a/include/hw/ppc/vof.h
> +++ b/include/hw/ppc/vof.h
> @@ -9,7 +9,7 @@
>   #include "qom/object.h"
>   #include "exec/address-spaces.h"
>   #include "exec/memory.h"
> -#include "cpu.h"
> +#include "exec/cpu-defs.h"
>   
>   typedef struct Vof {
>       uint64_t top_addr; /* copied from rma_size */


  reply	other threads:[~2022-12-16 16:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-13 12:35 [PATCH-for-8.0 0/4] ppc: Clean up few headers to make them target agnostic Philippe Mathieu-Daudé
2022-12-13 12:35 ` [PATCH-for-8.0 1/4] target/ppc/kvm: Add missing "cpu.h" and "exec/hwaddr.h" Philippe Mathieu-Daudé
2022-12-16 16:33   ` Daniel Henrique Barboza
2022-12-13 12:35 ` [PATCH-for-8.0 2/4] hw/ppc/vof: Do not include the full "cpu.h" Philippe Mathieu-Daudé
2022-12-16 16:33   ` Daniel Henrique Barboza [this message]
2022-12-13 12:35 ` [PATCH-for-8.0 3/4] hw/ppc/spapr: Reduce "vof.h" inclusion Philippe Mathieu-Daudé
2022-12-16 16:34   ` Daniel Henrique Barboza
2022-12-13 12:35 ` [PATCH-for-8.0 4/4] hw/ppc/spapr_ovec: Avoid target_ulong spapr_ovec_parse_vector() Philippe Mathieu-Daudé
2022-12-13 16:40   ` Harsh Prateek Bora
2022-12-16 16:47   ` Daniel Henrique Barboza
2022-12-21  9:46     ` Cédric Le Goater
2022-12-21 13:26       ` Daniel Henrique Barboza
2022-12-22  1:57         ` David Gibson
2022-12-16 16:54 ` [PATCH-for-8.0 0/4] ppc: Clean up few headers to make them target agnostic Daniel Henrique Barboza
2022-12-16 20:32   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d03a8c7-a7ef-cac8-9ca3-f06757131aab@gmail.com \
    --to=danielhb413@gmail.com \
    --cc=aik@ozlabs.ru \
    --cc=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=clg@kaod.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=groug@kaod.org \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).