From: "Kasireddy, Vivek" <vivek.kasireddy@intel.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: RE: [PATCH v6 03/13] virtio-gpu: Add udmabuf helpers
Date: Wed, 26 May 2021 19:32:14 +0000 [thread overview]
Message-ID: <4d125d60964d4512a012469baff90ab9@intel.com> (raw)
In-Reply-To: <20210526061633.taqutqwaagszygq3@sirius.home.kraxel.org>
Hi Gerd,
> Hi,
>
> > +#ifdef CONFIG_LINUX
>
> Seems wee need "#if defined(CONFIG_LINUX) && defined(F_GET_SEALS)" here
> to cover old linux versions. I see some build failures in gitlab CI due to
> F_GET_SEALS not being defined (crypto-old-nettle for example).
[Kasireddy, Vivek] Instead, I am planning to remove the ifdef and add a file in stubs
with the pixman dependency like you suggested. For seals, I think I could just include
qemu/memfd.h that has a definition for F_GET_SEALS.
>
> > +#include <sys/fcntl.h>
>
> gitlab ci (build-system-alpine):
>
> /usr/include/sys/fcntl.h:1:2: error: #warning redirecting incorrect #include <sys/fcntl.h> to
> <fcntl.h> [-Werror=cpp]
> 1 | #warning redirecting incorrect #include <sys/fcntl.h> to <fcntl.h>
[Kasireddy, Vivek] Ok, I'll replace sys/fcntl.h with just fcntl.h
>
> Otherwise series looks good and survived basic testing.
[Kasireddy, Vivek] Will send a v7 that would address the above issues.
Thanks,
Vivek
>
> take care,
> Gerd
next prev parent reply other threads:[~2021-05-26 19:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 22:30 [PATCH v6 00/13] virtio-gpu: Add support for Blob resources feature Vivek Kasireddy
2021-05-24 22:30 ` [PATCH v6 01/13] ui: Get the fd associated with udmabuf driver Vivek Kasireddy
2021-05-24 22:30 ` [PATCH v6 02/13] headers: Add udmabuf.h Vivek Kasireddy
2021-05-24 22:30 ` [PATCH v6 03/13] virtio-gpu: Add udmabuf helpers Vivek Kasireddy
2021-05-26 6:16 ` Gerd Hoffmann
2021-05-26 19:32 ` Kasireddy, Vivek [this message]
2021-05-24 22:30 ` [PATCH v6 04/13] virtio-gpu: Add virtio_gpu_find_check_resource Vivek Kasireddy
2021-05-24 22:30 ` [PATCH v6 05/13] virtio-gpu: Refactor virtio_gpu_set_scanout Vivek Kasireddy
2021-05-24 22:30 ` [PATCH v6 06/13] virtio-gpu: Refactor virtio_gpu_create_mapping_iov Vivek Kasireddy
2021-05-24 22:30 ` [PATCH v6 07/13] virtio-gpu: Add initial definitions for blob resources Vivek Kasireddy
2021-05-24 22:30 ` [PATCH v6 08/13] virtio-gpu: Add virtio_gpu_resource_create_blob Vivek Kasireddy
2021-05-24 22:30 ` [PATCH v6 09/13] ui/pixman: Add qemu_pixman_to_drm_format() Vivek Kasireddy
2021-05-24 22:31 ` [PATCH v6 10/13] virtio-gpu: Add helpers to create and destroy dmabuf objects Vivek Kasireddy
2021-05-24 22:31 ` [PATCH v6 11/13] virtio-gpu: Factor out update scanout Vivek Kasireddy
2021-05-24 22:31 ` [PATCH v6 12/13] virtio-gpu: Add virtio_gpu_set_scanout_blob Vivek Kasireddy
2021-05-24 22:31 ` [PATCH v6 13/13] virtio-gpu: Update cursor data using blob Vivek Kasireddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d125d60964d4512a012469baff90ab9@intel.com \
--to=vivek.kasireddy@intel.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).