From: Akihiko Odaki <akihiko.odaki@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH v2 0/2] ui/cocoa: updateUIInfo threading, autorelease pools
Date: Thu, 24 Feb 2022 20:46:32 +0900 [thread overview]
Message-ID: <4d2134d6-91e2-11ed-8d9e-873705a050d9@gmail.com> (raw)
In-Reply-To: <20220224101330.967429-1-peter.maydell@linaro.org>
Reviewed-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Tested-by: Akihiko Odaki <akihiko.odaki@gmail.com>
On 2022/02/24 19:13, Peter Maydell wrote:
> This patchset was originally provoked by Akihiko Odaki noting
> that we have some unnecessary creation and deletion of autorelease
> pools in the Cocoa UI code. Patch 2 deletes them; but to get there
> we need to do a bit of cleanup of the updateUIInfo support,
> which wasn't considering threads.
>
> Tested only very lightly.
>
> v1->v2 changes:
> * name method updateUIInfoLocked, to match existing handleEventLocked
> * don't call updateUIInfo in cocoa_display_init() -- this happens
> indirectly as a result of register_displaychangelistener()
>
> thanks
> -- PMM
>
> Peter Maydell (2):
> ui/cocoa.m: Fix updateUIInfo threading issues
> ui/cocoa.m: Remove unnecessary NSAutoreleasePools
>
> ui/cocoa.m | 31 ++++++++++++++++++++++---------
> 1 file changed, 22 insertions(+), 9 deletions(-)
>
prev parent reply other threads:[~2022-02-24 11:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 10:13 [PATCH v2 0/2] ui/cocoa: updateUIInfo threading, autorelease pools Peter Maydell
2022-02-24 10:13 ` [PATCH v2 1/2] ui/cocoa.m: Fix updateUIInfo threading issues Peter Maydell
2022-02-24 10:13 ` [PATCH v2 2/2] ui/cocoa.m: Remove unnecessary NSAutoreleasePools Peter Maydell
2022-02-24 11:46 ` Akihiko Odaki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d2134d6-91e2-11ed-8d9e-873705a050d9@gmail.com \
--to=akihiko.odaki@gmail.com \
--cc=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).