From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9BD6C64EC4 for ; Wed, 1 Mar 2023 01:22:28 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXB9v-0007ji-Ep; Tue, 28 Feb 2023 20:21:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXB9u-0007jS-Eu for qemu-devel@nongnu.org; Tue, 28 Feb 2023 20:21:30 -0500 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pXB9s-0007qD-SY for qemu-devel@nongnu.org; Tue, 28 Feb 2023 20:21:30 -0500 Received: by mail-pj1-x102e.google.com with SMTP id cp7-20020a17090afb8700b0023756229427so15618025pjb.1 for ; Tue, 28 Feb 2023 17:21:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PcFqs96t+/JGXoAq6gVLOXrsvN2eBSdItU0v2+/hoGo=; b=paODFKRjey7o7P1jgwuM3Zjx2TypXm/YjSco45/Haz6Z/tmUW+Aj4IP+jSf9p0GyG/ ExGvlim6SfRHhtPghyY1ttbYgMTMZFx49h/Nn7BcacfUEsANCzZYHlDVPXa/B78mDs4t /45+XUlXuJJml620niCU68i/44//z7J+2hLuOC6CCUIiFBEqo+DBK/VvIiWIjw4ZsJAK 34clCQTM7ujsdpde5ScMy+DzkIDLiimF5NwuLXtAnFCHlmMqrj1W4pMonW2DoC8FAM2D TZau5XGchAIqH75ONKEAto6AruDTmcF9CJjRr2fVV0aQc6QdqxwLikh5e1J2jaDF5EhC CfSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PcFqs96t+/JGXoAq6gVLOXrsvN2eBSdItU0v2+/hoGo=; b=3JBUxET+s1AFUP8eUHHlLFg1yO6c5paMKMs7AksikMX0V7X0p2Sniiw3O8+UXQDvO4 8KWU66bR43Wa4xbJh9Xpub629/nQsQJjmZA7ZkRFc/seRi1X5SRUGyzYrMkZSLNJay2B f21NQMM2qH5KT1s01i2RoEDwGIuGiucC049PG5OhWAboBdc2CTu++PsO44n82011OjkD LTuSXCYRuYRGAw0MKL+NjJn1eq7H/zyi11iKq7HDx35Tennuvp20NwrcLkzsVCJS39Ec pWMCUOCczL55rvAWOoigXEOHaEpK+UGOnxh+/iQ5wAu4quLhOw/K5AzvdMw9pZ/65oGp 3ZFA== X-Gm-Message-State: AO0yUKU2MJlKf0S4vBEnMlhw+E2REOHobdh2HWukQZffW5TZ+yhJ3S2g vN33Mdi5fnyOnzU7yNc0jMXCyA== X-Google-Smtp-Source: AK7set+G+oqBAZVWEI9qJdHdFShSHbt6tYFqMoZMLiCWAXGiaVKxUrnN0P49EB+HrL2KrZ6rGEYT9g== X-Received: by 2002:a05:6a21:3395:b0:cc:786d:2128 with SMTP id yy21-20020a056a21339500b000cc786d2128mr6111913pzb.53.1677633687013; Tue, 28 Feb 2023 17:21:27 -0800 (PST) Received: from [192.168.6.128] (rrcs-173-198-77-218.west.biz.rr.com. [173.198.77.218]) by smtp.gmail.com with ESMTPSA id s13-20020a65690d000000b004fcda0e59c3sm6292424pgq.69.2023.02.28.17.21.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Feb 2023 17:21:26 -0800 (PST) Message-ID: <4d42d401-9049-afc0-a5d3-9de28457afc2@linaro.org> Date: Tue, 28 Feb 2023 15:21:19 -1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH RESEND v7 1/9] target/arm: Move cortex sysregs into a separate file Content-Language: en-US To: Fabiano Rosas , qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Peter Maydell , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Paolo Bonzini , Claudio Fontana , Eduardo Habkost , Alexander Graf , Cornelia Huck References: <20230228192628.26140-1-farosas@suse.de> <20230228192628.26140-2-farosas@suse.de> From: Richard Henderson In-Reply-To: <20230228192628.26140-2-farosas@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::102e; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102e.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.092, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 2/28/23 09:26, Fabiano Rosas wrote: > The file cpu_tcg.c is about to be moved into the tcg/ directory, so > move the register definitions into a new file. > > Also move the function declaration to the more appropriate cpregs.h. > > Signed-off-by: Fabiano Rosas > --- > target/arm/cortex-regs.c | 69 ++++++++++++++++++++++++++++++++++++++++ > target/arm/cpregs.h | 6 ++++ > target/arm/cpu64.c | 1 + > target/arm/cpu_tcg.c | 59 ---------------------------------- > target/arm/internals.h | 6 ---- > target/arm/meson.build | 1 + > 6 files changed, 77 insertions(+), 65 deletions(-) > create mode 100644 target/arm/cortex-regs.c Reviewed-by: Richard Henderson r~