From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org, David Hildenbrand <david@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v1 6/6] softfloat: Support float_round_to_odd more places
Date: Fri, 22 Feb 2019 13:43:25 -0800 [thread overview]
Message-ID: <4d4521cb-8ce9-661d-9491-e350b4a6320f@linaro.org> (raw)
In-Reply-To: <20190222204500.24434-7-alex.bennee@linaro.org>
On 2/22/19 12:45 PM, Alex Bennée wrote:
> @@ -3526,6 +3551,8 @@ static float32 roundAndPackFloat32(flag zSign, int zExp, uint32_t zSig,
> case float_round_down:
> roundIncrement = zSign ? 0x7f : 0;
> break;
> + case float_round_to_odd:
> + roundIncrement = zSig & 0x80 ? 0 : 0x7f;
> default:
> abort();
I clearly missed a break here.
Since this didn't kill fp-test, are we missing a float128_to_float32 test?
r~
next prev parent reply other threads:[~2019-02-22 21:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 20:44 [Qemu-devel] [PATCH v1 0/6] fpu/next, mostly bits s390x tcg will need Alex Bennée
2019-02-22 20:44 ` [Qemu-devel] [PATCH v1 1/6] tests: Ignore fp test outputs Alex Bennée
2019-02-22 20:44 ` [Qemu-devel] [PATCH v1 2/6] softfloat: add float128_is_{normal, denormal} Alex Bennée
2019-02-22 20:44 ` [Qemu-devel] [PATCH v1 3/6] softfloat: Implement float128_to_uint32 Alex Bennée
2019-02-22 20:44 ` [Qemu-devel] [PATCH v1 4/6] tests/fp: add wrapping for f128_to_ui32 Alex Bennée
2019-02-22 21:40 ` Richard Henderson
2019-02-23 10:13 ` Alex Bennée
2019-02-22 20:44 ` [Qemu-devel] [PATCH v1 5/6] tests/fp: enable f128_to_ui[32/64] tests in float-to-uint Alex Bennée
2019-02-22 21:40 ` Richard Henderson
2019-02-22 20:45 ` [Qemu-devel] [PATCH v1 6/6] softfloat: Support float_round_to_odd more places Alex Bennée
2019-02-22 21:43 ` Richard Henderson [this message]
2019-02-23 10:11 ` Alex Bennée
2019-02-23 10:19 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d4521cb-8ce9-661d-9491-e350b4a6320f@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).