From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B1A1C61DA4 for ; Thu, 16 Feb 2023 04:25:11 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSVpF-0001yE-S7; Wed, 15 Feb 2023 23:24:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSVpE-0001wH-4u for qemu-devel@nongnu.org; Wed, 15 Feb 2023 23:24:52 -0500 Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSVpC-0000wP-CP for qemu-devel@nongnu.org; Wed, 15 Feb 2023 23:24:51 -0500 Received: by mail-pj1-x1041.google.com with SMTP id w20-20020a17090a8a1400b00233d7314c1cso4571137pjn.5 for ; Wed, 15 Feb 2023 20:24:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=v9I+TxywuEW+jAWEFG7AVpOypfV9nGpKAv5q4FyagMM=; b=vOXrwsHWGQjNi4f6WDS89zW7lG5Xwm9QzKJud/FElSy6KUhYGbVkVqU4aD58R0nqvu btziz8Liv4IwYWmvcEgPw4rFKh3TME/aGbyioxEiuFi0mlWdR1J5YY8Qlfjrn7oIgBe9 2O/oOS4JXpTIVqsvLWbpzxtl3QWaBGiToNL778UjxG8gvXa4ffR1VdUzDNC/tzWi5pVp 3DDrDkvtu09g7A+7cGrEu4VOHXVvc5h9iLlfKfEsoD3pE3dyXBgL9N9SHV88j5c0JXEZ uqmzaF1rGFmJO9hHXaks3o2fqaJHNxQplyDmJPnLXAkPzqEazIeLXzdN8sLoUq55/qGv mpYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=v9I+TxywuEW+jAWEFG7AVpOypfV9nGpKAv5q4FyagMM=; b=PfwHr1k64t48msn41uz2Kdkx0WKgbXA/PglEMFVjR0Dg+YigNJSjIiXA94Xg/nsB/6 8lCJ/UjQ4IxZ4Q/YTGfSD9QNzvQHrHzSOXkSAy2JrwS2x8ECn8jHO2reDARUg+AK2hwp /fVuAydi0wk2QqxE/UeLeZ5dvrJJOClwfapbOz00P0oZu2JfGnIdWmtvsOW+hg7ehqDs d2DWjA9iRGstVZOiLXwdm0kLHzZPhD6lxh0O86v34vAaAGCNdtt6rOBvglFm7x3D4Gys fkqNvXKmcCUFI7IPS8+rDdnrHv7cVO/vKcvugX34vgt3ENsdxZPnjn80o2YvVr2pWhSN qO8g== X-Gm-Message-State: AO0yUKU3T6g1E92ewonfKw7cbFPJ00rqpsQ71jPpx65aA1eL0j0oI5/M 2eHaxf3XpXVchqGLuffP+FITHQ== X-Google-Smtp-Source: AK7set+mn0II87o/vbFXKsB2LH7ucllnhM20nKdHLkTjPZuG4JKPlgA+2wl+BGL04hEtoBWtN475yQ== X-Received: by 2002:a17:902:fa03:b0:19a:a815:2881 with SMTP id la3-20020a170902fa0300b0019aa8152881mr4097347plb.37.1676521488472; Wed, 15 Feb 2023 20:24:48 -0800 (PST) Received: from [192.168.192.227] (rrcs-74-87-59-234.west.biz.rr.com. [74.87.59.234]) by smtp.gmail.com with ESMTPSA id u12-20020a17090282cc00b0019a7385079esm161865plz.123.2023.02.15.20.24.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Feb 2023 20:24:48 -0800 (PST) Message-ID: <4d474968-dce8-0d69-3e52-2c42a6398e4c@linaro.org> Date: Wed, 15 Feb 2023 18:24:44 -1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] Adding ability to change disassembler syntax in TCG plugins Content-Language: en-US To: Mikhail Tyutin , "qemu-devel@nongnu.org" , alex.bennee@linaro.org Cc: erdnaxe@crans.org, ma.mandourr@gmail.com References: <7d17f0cbb5ed4c90bbadd3992429006f@yadro.com> From: Richard Henderson In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1041; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1041.google.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.257, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 2/15/23 18:17, Mikhail Tyutin wrote: > ping > > patchew link: > https://patchew.org/QEMU/7d17f0cbb5ed4c90bbadd3992429006f@yadro.com/ > > 10.02.2023 18:24, Mikhail Tyutin wrote: >> This patch adds new function qemu_plugin_insn_disas_with_syntax() that allows TCG >> plugins to get disassembler string with non-default syntax if it wants to. >> >> Signed-off-by: Mikhail Tyutin Why? It's certainly not very generic, exposing a disassembly quirk for exactly one guest architecture. I mean, you could just as easily link your plugin directly to libcapstone via qemu_plugin_insn_data(). r~