From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
kwolf@redhat.com, jsnow@redhat.com, qemu-block@nongnu.org,
qemu-devel@nongnu.org, balaton@eik.bme.hu, shentey@gmail.com
Subject: Re: [PATCH v3 3/4] ide/via: don't attempt to set default BAR addresses
Date: Thu, 16 Nov 2023 14:14:47 +0100 [thread overview]
Message-ID: <4d48a1c5-381c-4c49-8454-861c29a2449f@linaro.org> (raw)
In-Reply-To: <20231116103355.588580-4-mark.cave-ayland@ilande.co.uk>
On 16/11/23 11:33, Mark Cave-Ayland wrote:
> The via-ide device currently attempts to set the default BAR addresses to the
> values shown in the datasheet, but this doesn't work for 2 reasons: firstly
> BARS 1-4 do not set the bottom 2 bits to PCI_BASE_ADDRESS_SPACE_IO, and
> secondly the initial PCI bus reset clears the values of all PCI device BARs
> after the device itself has been reset.
>
> Remove the setting of the default BAR addresses from via_ide_reset() to ensure
> there is no doubt that these values are never exposed to the guest.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
> hw/ide/via.c | 5 -----
> 1 file changed, 5 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-11-16 13:15 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 10:33 [PATCH v3 0/4] ide: implement simple legacy/native mode switching for PCI IDE controllers Mark Cave-Ayland
2023-11-16 10:33 ` [PATCH v3 1/4] ide/ioport: move ide_portio_list[] and ide_portio_list2[] definitions to IDE core Mark Cave-Ayland
2023-11-16 13:13 ` Philippe Mathieu-Daudé
2023-11-16 10:33 ` [PATCH v3 2/4] ide/pci: introduce pci_ide_update_mode() function Mark Cave-Ayland
2023-11-16 10:33 ` [PATCH v3 3/4] ide/via: don't attempt to set default BAR addresses Mark Cave-Ayland
2023-11-16 13:14 ` Philippe Mathieu-Daudé [this message]
2023-11-16 10:33 ` [PATCH v3 4/4] hw/ide/via: implement legacy/native mode switching Mark Cave-Ayland
2023-11-16 12:39 ` BALATON Zoltan
2023-11-16 13:48 ` [PATCH v3 0/4] ide: implement simple legacy/native mode switching for PCI IDE controllers Kevin Wolf
2023-11-16 21:59 ` BALATON Zoltan
2023-11-17 14:23 ` BALATON Zoltan
2023-11-20 10:17 ` Kevin Wolf
2023-11-20 11:10 ` BALATON Zoltan
2023-11-19 21:43 ` BALATON Zoltan
2023-11-19 22:11 ` BALATON Zoltan
2023-11-20 12:18 ` Mark Cave-Ayland
2023-11-20 13:09 ` BALATON Zoltan
2023-11-20 13:42 ` Kevin Wolf
2023-11-20 13:47 ` BALATON Zoltan
2023-11-20 14:00 ` BALATON Zoltan
2023-11-20 14:58 ` Kevin Wolf
2023-11-20 15:11 ` BALATON Zoltan
2023-11-21 9:48 ` Kevin Wolf
2023-11-20 14:28 ` Mark Cave-Ayland
2023-11-20 15:02 ` BALATON Zoltan
2023-11-21 9:12 ` Kevin Wolf
2023-11-21 10:16 ` Mark Cave-Ayland
2023-11-21 11:04 ` Peter Maydell
2023-11-20 12:26 ` Mark Cave-Ayland
2023-11-20 13:19 ` BALATON Zoltan
2023-11-20 13:30 ` BALATON Zoltan
2023-11-20 14:15 ` Mark Cave-Ayland
2023-11-20 14:58 ` BALATON Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d48a1c5-381c-4c49-8454-861c29a2449f@linaro.org \
--to=philmd@linaro.org \
--cc=balaton@eik.bme.hu \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shentey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).