From: Richard Henderson <richard.henderson@linaro.org>
To: Taylor Simpson <tsimpson@quicinc.com>, qemu-devel@nongnu.org
Cc: ale@rev.ng, bcain@quicinc.com, philmd@redhat.com
Subject: Re: [PATCH v2 2/4] Hexagon (target/hexagon) fix l2fetch instructions
Date: Tue, 1 Jun 2021 16:43:08 -0700 [thread overview]
Message-ID: <4d49d46a-f830-1eb2-8248-e9ccfc0f1856@linaro.org> (raw)
In-Reply-To: <1622589584-22571-3-git-send-email-tsimpson@quicinc.com>
On 6/1/21 4:19 PM, Taylor Simpson wrote:
> Y4_l2fetch == l2fetch(Rs32, Rt32)
> Y5_l2fetch == l2fetch(Rs32, Rtt32)
>
> The semantics for these instructions are present, but the encodings
> are missing.
>
> Note that these are treated as nops in qemu, so we add overrides.
>
> Test case added to tests/tcg/hexagon/misc.c
>
> Signed-off-by: Taylor Simpson<tsimpson@quicinc.com>
> ---
> target/hexagon/gen_tcg.h | 11 +++++++++++
> tests/tcg/hexagon/misc.c | 9 +++++++++
> target/hexagon/imported/encode_pp.def | 3 +++
> 3 files changed, 23 insertions(+)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2021-06-01 23:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 23:19 [PATCH v2 0/4] Hexagon (target/hexagon) bug fixes and cleanup Taylor Simpson
2021-06-01 23:19 ` [PATCH v2 1/4] Hexagon (target/hexagon) fix bug in fLSBNEW* Taylor Simpson
2021-06-01 23:41 ` Richard Henderson
2021-06-01 23:19 ` [PATCH v2 2/4] Hexagon (target/hexagon) fix l2fetch instructions Taylor Simpson
2021-06-01 23:43 ` Richard Henderson [this message]
2021-06-01 23:19 ` [PATCH v2 3/4] Hexagon (target/hexagon) cleanup gen_store_conditional[48] functions Taylor Simpson
2021-06-01 23:49 ` Richard Henderson
2021-06-01 23:19 ` [PATCH v2 4/4] Hexagon (target/hexagon) remove unused TCG variables Taylor Simpson
2021-06-01 23:51 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d49d46a-f830-1eb2-8248-e9ccfc0f1856@linaro.org \
--to=richard.henderson@linaro.org \
--cc=ale@rev.ng \
--cc=bcain@quicinc.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).